Rust: Disambiguate more method calls based on argument types #19927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
457aeee to
ee774f5
Compare
ee774f5 to
add2e0f
Compare
geoffw0
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
Looks good to me.
On DCA, we lose 1,491 results for rust/access-after-lifetime-ended. That's a lot of results and I couldn't convince myself any of the ones I looked at were true positives (the query is still @precision medium) so it's probably a good change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19749 follow-up.
Identifies more overlapping trait implementations, which can lead to an explosion in inferred types (as demonstrated by the added tests).