fix escaped names for import and apply #109
Merged
+4
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the handling of database names in KustoSchemaHandler.cs by removing the extra escaping logic for the databaseName parameter.
- Removed the unnecessary use of BracketIfIdentifier() in both Import and Apply methods.
- Updated logging and database handler instantiation to consistently use the unescaped databaseName.
Comments suppressed due to low confidence (1)
KustoSchemaTools/KustoSchemaHandler.cs:111
- The removal of the identifier escaping assumes that databaseName is safe for direct use. Please confirm that all database names are prevalidated or sanitized elsewhere to avoid issues with special characters.
var dbHandler = KustoDatabaseHandlerFactory.Create(clusters.Connections[0].Url, databaseName);
alex-slynko
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the handling of database names in
KustoSchemaHandler.csby removing unnecessary escaping logic and ensuring consistent usage of thedatabaseNameparameter. The changes improve code readability and reduce redundant operations.