Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Fix docker setup #385

Closed
wants to merge 1 commit into from
Closed

Fix docker setup #385

wants to merge 1 commit into from

Conversation

Zeko369
Copy link
Member

@Zeko369 Zeko369 commented Jul 30, 2020

  • I have read Chapter's contributing guidelines.
  • My pull request has a descriptive title (not a vague title like Update README.md).
  • My pull request targets the master branch of Chapter.

Closes #375

Rebuild our docker config.
Current -> uses host node_modules from docker (so unless your on linux and running same node docker container you could potentially run into problems with native modules + bad practice)
Plan -> when building docker container, run npm install inside of it

@allella
Copy link
Contributor

allella commented Aug 4, 2020

Fran was looking for assistance with Docker on Discord.

Here's the request

Anyone here think they know docker better than me (you probably do) as I have no f***ing idea what I'm doing, would you like to help with the docker-compose/docker file setup?
So if I'm not mistaken the flow should be

docker file -> at the end `npm install`
docker build
docker-compose up

@vaibhavsingh97 @3piecechickendinnerTB and @MihirSomani

@allella allella added the Help Wanted Extra attention is needed label Aug 4, 2020
@tomiiide
Copy link
Contributor

@Zeko369 @allella I have a docker setup that works, take a look at it and give feedback.
#398

@Zeko369 Zeko369 closed this Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Help Wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm ERR! in Docker
3 participants
@Zeko369 @allella @tomiiide