Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [firebase_dynamic_links] Enabling FlutterDeepLinkingEnabled in Info.plist file, Firebase dynamic links are handled as deep-links by default on iOS and Android #9469

Closed
Ayman-Barghout opened this issue Sep 5, 2022 · 13 comments
Assignees
Labels
platform: android Issues / PRs which are specifically for Android. platform: ios Issues / PRs which are specifically for iOS. plugin: dynamic_links resolution: invalid This doesn't seem right and might not belong here. type: bug Something isn't working

Comments

@Ayman-Barghout
Copy link

Bug report

Starting from version 3.0.0 the firebase_dynamic_links plugin started to handle dynamic links as deep-links by default on iOS, I tried on version 2.0.11 and it works normally but from version 3.0.0 onward - till latest version 4.3.6 this issue can be observed.

Steps to reproduce

Steps to reproduce the behavior:

  1. Run an app on the iOS simulator using version 3.0.0 or above (current version also works).
  2. run the xcrun simctl openurl booted <dynamic_link> command
  3. The dynamic link is treated as a deep-link even if it's handled in the onLink and getInitialLink

Expected behavior

The dynamic link should be only handled in the firebase_dynamic_links APIs (onLink and getInitialLink) and not handled by the OS as a deep-link AFAIK.

Sample project

I couldn't run the example project for firebase_dynamic_links but I guess it should be reproducible there, if not then please let me know so I can provide a really simple sample project.


Additional context

I am using go_router in my project, I am not sure if that might cause this issue but I doubt it.


Flutter doctor

Run flutter doctor and paste the output below:

Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.0.5, on macOS 12.3.1 21E258 darwin-arm, locale en-EG)
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.2)
[✓] VS Code (version 1.70.2)
[✓] Connected device (4 available)
[✓] HTTP Host Availability

• No issues found!

Flutter dependencies

Run flutter pub deps -- --style=compact and paste the output below:

Click To Expand
Dart SDK 2.17.6
Flutter SDK 3.0.5
done_flutter 1.44.0+195

dependencies:
- app_review 2.1.1+1 [http package_info url_launcher flutter]
- auto_size_text 3.0.0 [flutter]
- blurhash_dart 1.1.0 [image]
- cached_network_image 3.2.1 [flutter flutter_cache_manager octo_image cached_network_image_platform_interface cached_network_image_web]
- camera 0.10.0 [camera_android camera_avfoundation camera_platform_interface camera_web flutter flutter_plugin_android_lifecycle quiver]
- chewie 1.3.4 [cupertino_icons flutter provider video_player wakelock]
- cloud_firestore 1.0.6 [cloud_firestore_platform_interface cloud_firestore_web firebase_core firebase_core_platform_interface flutter meta]
- cloud_functions 3.3.6 [cloud_functions_platform_interface cloud_functions_web firebase_core firebase_core_platform_interface flutter]
- collection 1.16.0
- connectivity 3.0.3 [flutter meta connectivity_platform_interface connectivity_macos connectivity_for_web]
- cross_file 0.3.3+1 [js meta]
- device_calendar 4.2.0 [flutter collection sprintf timezone flutter_native_timezone]
- device_info_plus 3.2.4 [flutter device_info_plus_platform_interface device_info_plus_macos device_info_plus_linux device_info_plus_web device_info_plus_windows]
- done_models 0.0.1 [cloud_firestore cross_file flutter get_it logger sentry_flutter]
- done_ui 0.0.1 [flutter sprung]
- expandable 5.0.1 [flutter]
- expandable_bottom_sheet 1.1.1+1 [flutter]
- facebook_app_events 0.16.0 [flutter]
- file_picker 4.6.1 [flutter flutter_web_plugins flutter_plugin_android_lifecycle plugin_platform_interface ffi path win32]
- firebase_analytics 9.3.3 [firebase_analytics_platform_interface firebase_analytics_web firebase_core firebase_core_platform_interface flutter]
- firebase_auth 3.7.0 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- firebase_core 1.21.1 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_crashlytics 2.8.9 [firebase_core firebase_core_platform_interface firebase_crashlytics_platform_interface flutter stack_trace]
- firebase_dynamic_links 4.3.6 [firebase_core firebase_core_platform_interface firebase_dynamic_links_platform_interface flutter meta plugin_platform_interface]
- firebase_messaging 12.0.3 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta]
- firebase_storage 10.3.7 [firebase_core firebase_core_platform_interface firebase_storage_platform_interface firebase_storage_web flutter]
- flame 1.2.1 [collection flutter meta ordered_set vector_math]
- flutter 0.0.0 [characters collection material_color_utilities meta vector_math sky_engine]
- flutter_app_badger 1.4.0 [flutter]
- flutter_bloc 8.0.1 [flutter bloc provider]
- flutter_callkeep 0.2.3 [flutter]
- flutter_document_picker 5.1.0 [flutter]
- flutter_dropzone 3.0.5 [flutter flutter_dropzone_platform_interface flutter_dropzone_web]
- flutter_linkify 5.0.2 [flutter linkify]
- flutter_localizations 0.0.0 [flutter intl characters clock collection material_color_utilities meta path vector_math]
- flutter_markdown 0.6.10+3 [flutter markdown meta path]
- flutter_native_image 0.0.6+1 [flutter]
- flutter_pdfview 1.2.2 [flutter]
- flutter_svg 1.1.1+1 [flutter meta path_drawing vector_math xml]
- flutter_swipe_action_cell 3.0.4 [flutter]
- flutter_webrtc 0.8.12 [dart_webrtc flutter path_provider webrtc_interface]
- geolocator 8.2.1 [flutter geolocator_platform_interface geolocator_android geolocator_apple geolocator_web geolocator_windows]
- get_it 7.2.0 [async collection]
- go_router 4.2.8 [collection flutter flutter_web_plugins logging meta]
- google_maps_webservice 0.0.20-nullsafety.5 [http meta json_annotation]
- image 3.2.0 [archive meta xml]
- image_downloader 0.31.0 [flutter]
- image_picker 0.8.5+3 [flutter image_picker_android image_picker_for_web image_picker_ios image_picker_platform_interface]
- intercom_flutter 5.0.2 [flutter flutter_web_plugins intercom_flutter_platform_interface intercom_flutter_web]
- intl 0.17.0 [clock path]
- just_audio 0.9.28 [just_audio_platform_interface just_audio_web audio_session rxdart path path_provider async uuid crypto meta flutter]
- logger 1.1.0
- map_launcher 2.2.3 [flutter]
- overlay_support 2.0.1 [flutter async]
- package_info_plus 1.4.2 [flutter package_info_plus_platform_interface package_info_plus_linux package_info_plus_macos package_info_plus_windows package_info_plus_web]
- page_view_indicators 2.0.0 [flutter]
- path 1.8.1
- path_provider 2.0.11 [flutter path_provider_android path_provider_ios path_provider_linux path_provider_macos path_provider_platform_interface path_provider_windows]
- permission_handler 9.2.0 [flutter meta permission_handler_android permission_handler_apple permission_handler_windows permission_handler_platform_interface]
- personnummer 3.0.5
- phone_numbers_parser 5.0.5 [phone_number_metadata meta dart_countries]
- pin_code_fields 7.4.0 [flutter]
- pointer_interceptor 0.9.3+2 [flutter]
- proximity_screen_lock 1.1.0 [flutter proximity_screen_lock_ios proximity_screen_lock_android proximity_screen_lock_default proximity_screen_lock_platform_interface]
- pub_semver 2.1.1 [collection meta]
- rxdart 0.27.5
- sentry_flutter 6.9.1 [flutter flutter_web_plugins sentry package_info_plus meta]
- share 2.0.1 [meta mime flutter]
- shared_preferences 2.0.15 [flutter shared_preferences_android shared_preferences_ios shared_preferences_linux shared_preferences_macos shared_preferences_platform_interface shared_preferences_web shared_preferences_windows]
- smooth_star_rating_null_safety 1.0.4+2 [flutter]
- string_validator 0.3.0
- synchronized 3.0.0+2
- timeago 3.2.2
- universal_html 2.0.8 [async csslib charcode collection html meta source_span typed_data universal_io]
- universal_platform 1.0.0+1
- url_launcher 6.1.5 [flutter url_launcher_android url_launcher_ios url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows]
- uuid 3.0.6 [crypto]
- video_compress 3.1.1 [flutter]
- video_player 2.4.5 [flutter html video_player_android video_player_avfoundation video_player_platform_interface video_player_web]
- wakelock 0.6.2 [flutter meta wakelock_macos wakelock_platform_interface wakelock_web wakelock_windows]

dev dependencies:
- build_runner 2.2.0 [args async analyzer build build_config build_daemon build_resolvers build_runner_core code_builder collection crypto dart_style frontend_server_client glob graphs http_multi_server io js logging meta mime package_config path pool pub_semver pubspec_parse shelf shelf_web_socket stack_trace stream_transform timing watcher web_socket_channel yaml]
- flutter_driver 0.0.0 [file flutter flutter_test fuchsia_remote_debug_protocol path meta vm_service webdriver archive async boolean_selector characters charcode clock collection crypto matcher material_color_utilities platform process source_span stack_trace stream_channel string_scanner sync_http term_glyph test_api typed_data vector_math]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher material_color_utilities meta source_span stream_channel string_scanner term_glyph]
- gen_lang 0.2.0-nullsafety.0 [args path ansicolor]
- go_router_builder 1.0.8 [analyzer async build build_config collection meta path path_to_regexp source_gen source_helper]
- lang_table 0.4.0 [args path ansicolor http]
- test 1.21.1 [analyzer async boolean_selector collection coverage http_multi_server io js node_preamble package_config path pool shelf shelf_packages_handler shelf_static shelf_web_socket source_span stack_trace stream_channel typed_data web_socket_channel webkit_inspection_protocol yaml test_api test_core]
- very_good_analysis 2.4.0

transitive dependencies:
- _fe_analyzer_shared 46.0.0 [meta]
- analyzer 4.6.0 [_fe_analyzer_shared collection convert crypto glob meta package_config path pub_semver source_span watcher yaml]
- ansicolor 2.0.1
- archive 3.1.11 [crypto path]
- args 2.3.0
- async 2.8.2 [collection meta]
- audio_session 0.1.10 [flutter flutter_web_plugins rxdart meta]
- bloc 8.0.3 [meta]
- boolean_selector 2.1.0 [source_span string_scanner]
- build 2.3.0 [analyzer async convert crypto glob logging meta path]
- build_config 1.1.0 [checked_yaml json_annotation path pubspec_parse yaml]
- build_daemon 3.1.0 [built_collection built_value http_multi_server logging path pool shelf shelf_web_socket stream_transform watcher web_socket_channel]
- build_resolvers 2.0.9 [analyzer async build crypto graphs logging path package_config pool pub_semver stream_transform yaml]
- build_runner_core 7.2.2 [async build build_config build_resolvers collection convert crypto glob graphs json_annotation logging meta path package_config pool timing watcher yaml]
- built_collection 5.1.1
- built_value 8.2.2 [built_collection collection fixnum meta]
- cached_network_image_platform_interface 1.0.0 [flutter flutter_cache_manager]
- cached_network_image_web 1.0.1 [flutter flutter_cache_manager cached_network_image_platform_interface]
- camera_android 0.10.0 [camera_platform_interface flutter flutter_plugin_android_lifecycle stream_transform]
- camera_avfoundation 0.9.8+2 [camera_platform_interface flutter stream_transform]
- camera_platform_interface 2.2.0 [cross_file flutter plugin_platform_interface stream_transform]
- camera_web 0.3.0 [camera_platform_interface flutter flutter_web_plugins stream_transform]
- characters 1.2.0
- charcode 1.3.1
- checked_yaml 2.0.1 [json_annotation source_span yaml]
- clock 1.1.0
- cloud_firestore_platform_interface 4.0.2 [collection firebase_core flutter meta plugin_platform_interface]
- cloud_firestore_web 1.0.6 [cloud_firestore_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js]
- cloud_functions_platform_interface 5.1.15 [firebase_core flutter meta plugin_platform_interface]
- cloud_functions_web 4.3.4 [cloud_functions_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js]
- code_builder 4.1.0 [built_collection built_value collection matcher meta]
- connectivity_for_web 0.4.0 [connectivity_platform_interface flutter_web_plugins flutter]
- connectivity_macos 0.2.0 [flutter]
- connectivity_platform_interface 2.0.1 [flutter meta plugin_platform_interface]
- convert 3.0.1 [typed_data]
- coverage 1.2.0 [args logging package_config path source_maps stack_trace vm_service]
- crypto 3.0.1 [collection typed_data]
- csslib 0.17.0 [source_span]
- cupertino_icons 1.0.5
- dart_countries 3.0.2
- dart_style 2.2.3 [analyzer args path pub_semver source_span]
- dart_webrtc 1.0.6 [webrtc_interface]
- device_info_plus_linux 2.1.1 [device_info_plus_platform_interface file flutter meta]
- device_info_plus_macos 2.2.3 [device_info_plus_platform_interface flutter]
- device_info_plus_platform_interface 2.3.0+1 [flutter meta plugin_platform_interface]
- device_info_plus_web 2.1.0 [device_info_plus_platform_interface flutter_web_plugins flutter]
- device_info_plus_windows 2.1.1 [device_info_plus_platform_interface ffi flutter win32]
- fake_async 1.3.0 [clock collection]
- ffi 1.1.2
- file 6.1.2 [meta path]
- firebase_analytics_platform_interface 3.3.3 [firebase_core flutter meta plugin_platform_interface]
- firebase_analytics_web 0.4.2+3 [firebase_analytics_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js]
- firebase_auth_platform_interface 6.6.0 [collection firebase_core flutter meta plugin_platform_interface]
- firebase_auth_web 4.3.0 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser intl js meta]
- firebase_core_platform_interface 4.5.1 [collection flutter flutter_test meta plugin_platform_interface]
- firebase_core_web 1.7.2 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- firebase_crashlytics_platform_interface 3.2.15 [collection firebase_core flutter meta plugin_platform_interface]
- firebase_dynamic_links_platform_interface 0.2.3+11 [firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_platform_interface 4.1.3 [firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_web 3.1.3 [firebase_core firebase_core_web firebase_messaging_platform_interface flutter flutter_web_plugins js meta]
- firebase_storage_platform_interface 4.1.15 [collection firebase_core flutter meta plugin_platform_interface]
- firebase_storage_web 3.3.5 [async firebase_core firebase_core_web firebase_storage_platform_interface flutter flutter_web_plugins http js meta]
- fixnum 1.0.0
- flutter_blurhash 0.6.8 [flutter]
- flutter_cache_manager 3.3.0 [clock collection file flutter http path path_provider pedantic rxdart sqflite uuid]
- flutter_dropzone_platform_interface 2.0.5 [flutter plugin_platform_interface]
- flutter_dropzone_web 3.0.8 [flutter flutter_web_plugins flutter_dropzone_platform_interface js]
- flutter_native_timezone 2.0.0 [flutter_web_plugins flutter js]
- flutter_plugin_android_lifecycle 2.0.5 [flutter]
- flutter_web_plugins 0.0.0 [flutter js characters collection material_color_utilities meta vector_math]
- frontend_server_client 2.1.2 [async path]
- fuchsia_remote_debug_protocol 0.0.0 [process vm_service file meta path platform]
- geolocator_android 3.2.1 [flutter geolocator_platform_interface]
- geolocator_apple 2.1.1+1 [flutter geolocator_platform_interface]
- geolocator_platform_interface 4.0.6 [flutter plugin_platform_interface vector_math meta]
- geolocator_web 2.1.4 [flutter flutter_web_plugins geolocator_platform_interface]
- geolocator_windows 0.1.0 [flutter geolocator_platform_interface]
- glob 2.0.1 [async collection file path pedantic string_scanner]
- graphs 2.1.0 [collection]
- html 0.15.0 [csslib source_span]
- http 0.13.3 [async http_parser meta path pedantic]
- http_multi_server 3.0.1 [async]
- http_parser 4.0.0 [charcode collection source_span string_scanner typed_data]
- image_picker_android 0.8.5+1 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface]
- image_picker_for_web 2.1.8 [flutter flutter_web_plugins image_picker_platform_interface]
- image_picker_ios 0.8.5+5 [flutter image_picker_platform_interface]
- image_picker_platform_interface 2.5.0 [cross_file flutter http plugin_platform_interface]
- intercom_flutter_platform_interface 1.0.0 [flutter plugin_platform_interface]
- intercom_flutter_web 0.0.2 [flutter flutter_web_plugins intercom_flutter_platform_interface uuid]
- io 1.0.3 [meta path string_scanner]
- js 0.6.4
- json_annotation 4.6.0 [meta]
- just_audio_platform_interface 4.2.0 [flutter plugin_platform_interface]
- just_audio_web 0.4.7 [just_audio_platform_interface flutter flutter_web_plugins]
- linkify 4.0.0
- logging 1.0.2
- markdown 5.0.0 [args charcode meta]
- matcher 0.12.11 [stack_trace]
- material_color_utilities 0.1.4
- meta 1.7.0
- mime 1.0.0
- nested 1.0.0 [flutter]
- node_preamble 2.0.1
- octo_image 1.0.1 [flutter flutter_blurhash]
- ordered_set 5.0.0
- package_config 2.0.2 [path]
- package_info 2.0.0 [flutter]
- package_info_plus_linux 1.0.5 [package_info_plus_platform_interface flutter path]
- package_info_plus_macos 1.3.0 [flutter]
- package_info_plus_platform_interface 1.0.2 [flutter meta plugin_platform_interface]
- package_info_plus_web 1.0.5 [flutter flutter_web_plugins http meta package_info_plus_platform_interface]
- package_info_plus_windows 1.0.5 [package_info_plus_platform_interface ffi flutter win32]
- path_drawing 1.0.0 [vector_math meta path_parsing flutter]
- path_parsing 1.0.0 [vector_math meta]
- path_provider_android 2.0.12 [flutter path_provider_platform_interface]
- path_provider_ios 2.0.8 [flutter path_provider_platform_interface]
- path_provider_linux 2.1.7 [ffi flutter path path_provider_platform_interface xdg_directories]
- path_provider_macos 2.0.0 [flutter]
- path_provider_platform_interface 2.0.1 [flutter meta platform plugin_platform_interface]
- path_provider_windows 2.0.7 [ffi flutter path path_provider_platform_interface win32]
- path_to_regexp 0.4.0
- pedantic 1.11.0
- permission_handler_android 9.0.2+1 [flutter permission_handler_platform_interface]
- permission_handler_apple 9.0.4 [flutter permission_handler_platform_interface]
- permission_handler_platform_interface 3.7.0 [flutter meta plugin_platform_interface]
- permission_handler_windows 0.1.0 [flutter permission_handler_platform_interface]
- petitparser 5.0.0 [meta]
- phone_number_metadata 5.0.3 [path dart_countries]
- platform 3.1.0
- plugin_platform_interface 2.1.2 [meta]
- pool 1.5.0 [async stack_trace]
- process 4.2.4 [file path platform]
- provider 6.0.3 [collection flutter nested]
- proximity_screen_lock_android 1.0.0 [flutter proximity_screen_lock_platform_interface]
- proximity_screen_lock_default 1.0.0 [flutter flutter_web_plugins proximity_screen_lock_platform_interface]
- proximity_screen_lock_ios 1.0.0 [flutter proximity_screen_lock_platform_interface]
- proximity_screen_lock_platform_interface 1.0.1 [flutter plugin_platform_interface]
- pubspec_parse 1.0.0 [checked_yaml collection json_annotation pub_semver yaml]
- quiver 3.0.1+1 [matcher]
- sentry 6.9.1 [http meta stack_trace uuid]
- shared_preferences_android 2.0.12 [flutter shared_preferences_platform_interface]
- shared_preferences_ios 2.1.1 [flutter shared_preferences_platform_interface]
- shared_preferences_linux 2.1.1 [file flutter path path_provider_linux path_provider_platform_interface shared_preferences_platform_interface]
- shared_preferences_macos 2.0.0 [shared_preferences_platform_interface flutter]
- shared_preferences_platform_interface 2.0.0 [flutter]
- shared_preferences_web 2.0.0 [shared_preferences_platform_interface flutter flutter_web_plugins meta]
- shared_preferences_windows 2.1.1 [file flutter path path_provider_platform_interface path_provider_windows shared_preferences_platform_interface]
- shelf 1.2.0 [async collection http_parser path stack_trace stream_channel]
- shelf_packages_handler 3.0.0 [path shelf shelf_static]
- shelf_static 1.1.0 [convert http_parser mime path shelf]
- shelf_web_socket 1.0.1 [shelf stream_channel web_socket_channel]
- sky_engine 0.0.99
- source_gen 1.2.2 [analyzer async build dart_style glob meta path source_span yaml]
- source_helper 1.3.2 [analyzer collection source_gen]
- source_map_stack_trace 2.1.0 [path stack_trace source_maps]
- source_maps 0.10.10 [source_span]
- source_span 1.8.2 [collection path term_glyph]
- sprintf 6.0.0
- sprung 3.0.0 [flutter]
- sqflite 2.0.2 [flutter sqflite_common path]
- sqflite_common 2.2.0 [synchronized path meta]
- stack_trace 1.10.0 [path]
- stream_channel 2.1.0 [async]
- stream_transform 2.0.0
- string_scanner 1.1.0 [charcode source_span]
- sync_http 0.3.0
- term_glyph 1.2.0
- test_api 0.4.9 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
- test_core 0.4.13 [analyzer async args boolean_selector collection coverage frontend_server_client glob io meta package_config path pool source_map_stack_trace source_maps source_span stack_trace stream_channel vm_service yaml matcher test_api]
- timezone 0.8.0 [path]
- timing 1.0.0 [json_annotation]
- typed_data 1.3.0 [collection]
- universal_io 2.0.4 [collection crypto meta typed_data]
- url_launcher_android 6.0.17 [flutter url_launcher_platform_interface]
- url_launcher_ios 6.0.17 [flutter url_launcher_platform_interface]
- url_launcher_linux 2.0.0 [flutter]
- url_launcher_macos 2.0.0 [flutter]
- url_launcher_platform_interface 2.1.0 [flutter plugin_platform_interface]
- url_launcher_web 2.0.0 [url_launcher_platform_interface meta flutter flutter_web_plugins]
- url_launcher_windows 2.0.0 [flutter]
- vector_math 2.1.2
- video_player_android 2.3.8 [flutter video_player_platform_interface]
- video_player_avfoundation 2.3.1 [flutter video_player_platform_interface]
- video_player_platform_interface 5.1.1 [flutter plugin_platform_interface]
- video_player_web 2.0.7 [flutter flutter_web_plugins video_player_platform_interface]
- vm_service 8.2.2
- wakelock_macos 0.4.0 [flutter flutter_web_plugins wakelock_platform_interface]
- wakelock_platform_interface 0.3.0 [flutter meta]
- wakelock_web 0.4.0 [flutter flutter_web_plugins js wakelock_platform_interface]
- wakelock_windows 0.2.0 [flutter wakelock_platform_interface win32]
- watcher 1.0.0 [async path pedantic]
- web_socket_channel 2.1.0 [async crypto stream_channel]
- webdriver 3.0.0 [archive matcher path stack_trace sync_http]
- webkit_inspection_protocol 1.0.0 [logging]
- webrtc_interface 1.0.5
- win32 2.6.1 [ffi]
- xdg_directories 0.2.0 [meta path process]
- xml 6.1.0 [collection meta petitparser]
- yaml 3.1.0 [collection source_span string_scanner]

@Ayman-Barghout Ayman-Barghout added Needs Attention This issue needs maintainer attention. type: bug Something isn't working labels Sep 5, 2022
@darshankawar darshankawar added the triage Issue is currently being triaged. label Sep 6, 2022
@darshankawar
Copy link

Thanks for the detailed report @Ayman-Barghout

From plugin's change log for version 3.0.0, I see that only the Android minSdk version was updated and there were not any changes related to actual code. https://pub.dev/packages/firebase_dynamic_links/changelog#300

I tried the plugin's example on iOS, but didn't notice the behavior.

I am using go_router in my project

Can you try without it and see if you are still able to replicate the behavior ? If so, a minimal code sample would be good to analyze further.

@darshankawar darshankawar added blocked: customer-response Waiting for customer response, e.g. more information was requested. and removed Needs Attention This issue needs maintainer attention. labels Sep 6, 2022
@Ayman-Barghout
Copy link
Author

Ayman-Barghout commented Sep 6, 2022

Thanks for your sincere reply @darshankawar

I have always used ^3.0.0 so it could be a version after 3.0.0, 3.0.2 for instance, but we can address the latest version of firebase_dynamic_links.

I think I know why it is happening and it's not mainly because of go_router but when using Router and adding the deep-linking configuration:

<key>FlutterDeepLinkingEnabled</key>
<true/>

Screen Shot 2022-09-06 at 10 41 24 AM

When we remove the above info.plist entry, everything works as expected - except for deep-linking 😅 -.

So, I think some interaction between Flutter's deep-linking and firebase_dynamic_links on the latest versions is causing this behavior, as on version ^2.0.0 this doesn't occur.

Related SO post: https://stackoverflow.com/questions/73262332/flutter-ios-firebase-dynamic-link-push-named-page-with-the-link-value

So the criteria for reproducing this issue:

  1. Use MaterialApp.router.
  2. Enable Flutter deep-linking for iOS
  3. Use firebase_dynamic_links on latest version.
  4. run the xcrun simctl openurl booted <dynamic_link> command

Thanks a lot for your patience and help!

@google-oss-bot google-oss-bot added Needs Attention This issue needs maintainer attention. and removed blocked: customer-response Waiting for customer response, e.g. more information was requested. labels Sep 6, 2022
@darshankawar
Copy link

Thanks for these details and analysis. Using steps to replicate above, I am seeing same behavior as reported, ie, the dynamic links are handled as deep links by default on iOS, when we enable Flutter deep-linking as mentioned above.

/cc @russellwheatley

@darshankawar darshankawar changed the title 🐛 [firebase_dynamic_links] Firebase dynamic links handled as deep-links by default on iOS 🐛 [firebase_dynamic_links] Enabling FlutterDeepLinkingEnabled in Info.plist file, Firebase dynamic links are handled as deep-links by default on iOS Sep 6, 2022
@darshankawar darshankawar added plugin: dynamic_links platform: ios Issues / PRs which are specifically for iOS. and removed Needs Attention This issue needs maintainer attention. triage Issue is currently being triaged. labels Sep 6, 2022
@russellwheatley russellwheatley self-assigned this Sep 8, 2022
@Ayman-Barghout
Copy link
Author

Hello, thanks for the great work on FlutterFire packages, I don't mean to nag but this issue is keeping us away from using firebase_ui_auth or upgrading our firebase dependencies, are there any updates regarding it 😓?

@cedvdb
Copy link

cedvdb commented Dec 6, 2022

I've the same issue on android, this does not seem to be specific to ios. @darshankawar have you tried on android ? It is achieved by adding this to android manifest under <activity>

            <meta-data android:name="flutter_deeplinking_enabled" android:value="true" />

We are using this to return to the application after a succesful payment with the bank (3DS2) which redirects with a custom scheme in order to not have the native "open this link with chome or app" dialog.

Removing deeplinking does not seem to be an option for us.

@blopker
Copy link

blopker commented Dec 7, 2022

I've just ran into this issue as well. It seems like the deep linking plugin (flutter_deeplinking_enabled=true) captures all links, including Dynamic Links, and triggers a Navigation with the URL's path. It does this with all hostnames.

So, say I have link.example.com for my Dynamic Link hostname and app.example.com for deep linking. Going to link.example.com/dkjie8 triggers an app navigation to /dkjie8 AND causes firebase_dynamic_links to trigger. The navigation happens faster and the app crashes/404's before the app can handle the Dynamic Link properly. Going to app.example.com/screen navigates to /screen as expected.

I'm not sure how to workaround it or what the fix might be though.

@Ayman-Barghout
Copy link
Author

@blopker for us, we have to keep the version to a really old one firebase_dynamic_links: ^2.0.1 which is less than ideal but works for us (even though we are eager to upgrade our firebase plugins, but are blocked due to this issue).

@blopker
Copy link

blopker commented Dec 7, 2022

That's fair. Our solution was to just not use Dynamic Links. The login page on our web app has some minimal routing logic to direct people to get the Android or iOS app. Also not ideal, but deeps links are more important than dynamic links for us right now.

@cedvdb
Copy link

cedvdb commented Dec 12, 2022

@blopker @Ayman-Barghout can anyone of you confirm this issue is also valid for android ? The title is misleading if that's the case.

@blopker
Copy link

blopker commented Dec 12, 2022

Yes, this is also valid for Android.

@cedvdb
Copy link

cedvdb commented Dec 15, 2022

@darshankawar Could you edit the title and labels to add platform android ? Sorry to bug everyone for that but I don't want this issue to be mislabeled and lose prioritization points as a result.

@darshankawar darshankawar changed the title 🐛 [firebase_dynamic_links] Enabling FlutterDeepLinkingEnabled in Info.plist file, Firebase dynamic links are handled as deep-links by default on iOS 🐛 [firebase_dynamic_links] Enabling FlutterDeepLinkingEnabled in Info.plist file, Firebase dynamic links are handled as deep-links by default on iOS and Android Dec 16, 2022
@darshankawar darshankawar added the platform: android Issues / PRs which are specifically for Android. label Dec 16, 2022
@russellwheatley
Copy link
Member

I'm not sure how Firebase Dynamic Links is supposed to solve this problem. If you read Flutter's documentation here, it states:

If you have written a plugin to handle deep links, as described in “Deep Links and Flutter applications” (an article on Medium), it will continue to work until you opt-in to this behavior by adding FlutterDeepLinkingEnabled to Info.plist or flutter_deeplinking_enabled to AndroidManifest.xml, respectively.

We don't have input on how Flutter uses deep links, it is out of our control.

@Ayman-Barghout could you elaborate what you mean by this?

Starting from version 3.0.0 the firebase_dynamic_links plugin started to handle dynamic links as deep-links by default on iOS

I was under the impression Firebase iOS Dynamic Links has always used deep links? What was the alternative they were using?

Again, not sure this would be something we could change on FlutterFire (assuming there has been a shift to deep links as you mentioned), this would be an implementation change on the Firebase iOS SDK which FlutterFire is a wrapper around.

@russellwheatley russellwheatley added the blocked: customer-response Waiting for customer response, e.g. more information was requested. label Jan 30, 2023
@Ayman-Barghout
Copy link
Author

I'm not sure how Firebase Dynamic Links is supposed to solve this problem. If you read Flutter's documentation here, it states:

If you have written a plugin to handle deep links, as described in “Deep Links and Flutter applications” (an article on Medium), it will continue to work until you opt-in to this behavior by adding FlutterDeepLinkingEnabled to Info.plist or flutter_deeplinking_enabled to AndroidManifest.xml, respectively.

We don't have input on how Flutter uses deep links, it is out of our control.

@Ayman-Barghout could you elaborate what you mean by this?

Starting from version 3.0.0 the firebase_dynamic_links plugin started to handle dynamic links as deep-links by default on iOS

I was under the impression Firebase iOS Dynamic Links has always used deep links? What was the alternative they were using?

Again, not sure this would be something we could change on FlutterFire (assuming there has been a shift to deep links as you mentioned), this would be an implementation change on the Firebase iOS SDK which FlutterFire is a wrapper around.

I think you got a solid point, everything does work as expected since dynamic links are set up as deep links, maybe what we needed was more control over which domains/URLs to navigate to and which to not, but that's something that is handled by Flutter.

What we did is use uni_links for deep-linking and filter which domains/URLs we should route in-app, closing this issue as it's not related to FlutterFire.

@darshankawar darshankawar added resolution: invalid This doesn't seem right and might not belong here. and removed blocked: customer-response Waiting for customer response, e.g. more information was requested. labels Feb 1, 2023
@firebase firebase locked and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: android Issues / PRs which are specifically for Android. platform: ios Issues / PRs which are specifically for iOS. plugin: dynamic_links resolution: invalid This doesn't seem right and might not belong here. type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants