Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth Emulator batchGet should return nextPageToken if page is full #3231

Closed
yuchenshi opened this issue Mar 25, 2021 · 0 comments · Fixed by #3253
Closed

Auth Emulator batchGet should return nextPageToken if page is full #3231

yuchenshi opened this issue Mar 25, 2021 · 0 comments · Fixed by #3253
Assignees

Comments

@yuchenshi
Copy link
Member

Expected Behavior

If there are enough users to fill a whole page size (whatever that is), a nextPageToken should be returned even if the next page would be empty. (I've tested in production and this is the behavior indeed.)

Actual Behavior

The Auth Emulator returns no page token if number of users is same as page size. This causes tests failures like https://github.com/firebase/firebase-admin-node/pull/1204/checks?check_run_id=2189478758.

We had to disable that tests for now (firebase/firebase-admin-node#1205) and that should be reverted after the fix land in a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant