Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing PhoneMultiFactorInfo type in v9 #5922

Closed
addisonElliott opened this issue Jan 24, 2022 · 2 comments · Fixed by #5924
Closed

Missing PhoneMultiFactorInfo type in v9 #5922

addisonElliott opened this issue Jan 24, 2022 · 2 comments · Fixed by #5924
Labels
api: auth v9

Comments

@addisonElliott
Copy link

Describe your environment

  • Operating System version: Google Chrome
  • Browser version: 97.0.4692.99 (64-bit)
  • Firebase SDK version: 9.6.4
  • Firebase Product: auth

[REQUIRED] Describe the problem

Since v9, the PhoneMultiFactorInfo is not exported from firebase/auth. This type is accessible in v8 firebase.auth.PhoneMultiFactorInfo.

In v9, there's still an enrolledFactors item that is of the type PhoneMultiFactorInfo. I know this because I do enrolledFactors[0].phoneNumber and it is still returning the 2FA phone number. It's just that the type is missing in the SDK.

See here for v8: https://github.com/firebase/firebase-js-sdk/blob/master/packages/auth-types/index.d.ts#L376-L378

Not present in v9 public types: https://github.com/firebase/firebase-js-sdk/blob/master/packages/auth/src/model/public_types.ts
@rizafran rizafran added the v9 label Jan 24, 2022
@sam-gc sam-gc mentioned this issue Jan 24, 2022
Merged
@sam-gc
Copy link
Contributor

sam-gc commented Jan 24, 2022

Hi @addisonElliott, thanks for filing this. The linked PR will add the missing interface

@addisonElliott
Copy link
Author

Thanks for the speedy response!

@google-oss-bot google-oss-bot mentioned this issue Jan 26, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api: auth v9
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Auth] Add missing PhoneMultiFactorInfo public interface firebase/firebase-js-sdk
4 participants
@addisonElliott @sam-gc @google-oss-bot @rizafran