Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing type declarations in Auth interface #573

Closed
gonzaloriestra opened this issue Mar 19, 2018 · 7 comments
Closed

Missing type declarations in Auth interface #573

gonzaloriestra opened this issue Mar 19, 2018 · 7 comments
Assignees
@wti806
Labels
api: auth

Comments

@gonzaloriestra
Copy link
Contributor

[REQUIRED] Describe your environment

  • Operating System version: Ubuntu 17.10
  • Firebase SDK version: 4.11.0
  • Firebase Product: Auth

[REQUIRED] Describe the problem

Steps to reproduce:

If you try to use the Auth function createUserAndRetrieveDataWithEmailAndPassword, Typescript complaints about it: Property 'createUserAndRetrieveDataWithEmailAndPassword' does not exist on type 'Auth'.

Relevant Code:

In firebase/index.d.ts the function createUserAndRetrieveDataWithEmailAndPassword should be defined in the Auth interface, as it is in auth-types/index.d.ts.
@gonzaloriestra gonzaloriestra mentioned this issue Mar 19, 2018
Merged
@gonzaloriestra
Copy link
Contributor Author

The function signInAndRetrieveDataWithEmailAndPassword is also missing.

@gonzaloriestra gonzaloriestra changed the title Missing type declaration in Auth interface Missing types declaration in Auth interface Mar 19, 2018
@gonzaloriestra gonzaloriestra changed the title Missing types declaration in Auth interface Missing type declarations in Auth interface Mar 19, 2018
@bojeil-google
Copy link
Contributor

It is right here: https://github.com/firebase/firebase-js-sdk/blob/master/packages/auth-types/index.d.ts#L280

@gonzaloriestra
Copy link
Contributor Author

@bojeil-google Thanks, but shouldn't it be also defined in firebase/index.d.ts?

@bojeil-google
Copy link
Contributor

Ah, i had forgotten about this file. There are a bunch of missing APIs there. Ok, will look into adding the missing APIs.

@Splaktar
Copy link

Looks like this got solved in 9d00c6f

@gonzaloriestra
Copy link
Contributor Author

@Splaktar I just added one function, but as bojeil-google said, there are more pending functions to add, like signInAndRetrieveDataWithEmailAndPassword.

@bojeil-google
Copy link
Contributor

The missing ones should be available now.

@firebase firebase locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wti806 wti806

Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Splaktar @bojeil-google @gonzaloriestra @google-oss-bot @wti806