Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate identifier errors when compiling a project which links a module #474

Closed
SamVerschueren opened this issue Jan 30, 2018 · 3 comments · Fixed by #599
Closed

Duplicate identifier errors when compiling a project which links a module #474

SamVerschueren opened this issue Jan 30, 2018 · 3 comments · Fixed by #599

Comments

@SamVerschueren
Copy link

SamVerschueren commented Jan 30, 2018

Describe your environment

  • Operating System version: macOS Sierra
  • Firebase SDK version: 4.9.0
  • Firebase Product: auth, database

Describe the problem

We are using a monorepo and have a module (A) which depends on another module (B). Both of firebase listed as dependency. Compiling module B is not a problem. Compiling module A however is. These errors are showing up:

screen shot 2018-01-28 at 19 19 31

I tweeted about this, and @DanielRosenwasser replied that it should be fixed in here. https://twitter.com/drosenwasser/status/957872358978609152

I was able to solve it with paths mappings in tsconfig.json, but would be nice if it just worked without.

Steps to reproduce:

  1. Create 2 modules which both have firebase as dependency
  2. Link one module to the other yarn add link:../module-b
  3. Compile

(Better to look at the reproduction repository)

Relevant Code:

Here's the repository I created to reproduce the problem. https://github.com/SamVerschueren/firebase-duplicate-tsd

// @jshcrowthe

@google-oss-bot
Copy link
Contributor

Hmmm this issue does not seem to follow the issue template. Make sure you provide all the required information.

@0x-r4bbit
Copy link

I can confirm this issue. This a problem that exists with firebase version 4.9.0+.

@0x-r4bbit
Copy link

🎉

@firebase firebase locked and limited conversation to collaborators Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants