-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esbuild gives comparison to -0 compiling firestore #3814
Labels
Comments
@ojanvafai Thanks for letting us know about this. This is certainly something we can fix. I will prepare a PR right away. |
Wow. 3 days since filing! I had low hopes this had any chance of getting fixed at all. Thanks. :) |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
esbuild gives the following error compiling firestore:
Technically both 0 and -0 work the same with === operator. The esbuild warning seems reasonable in general. Can we change the -0 to a 0? In some ways that's also more clear since -0 indicates that it needs to be -0 for the code to work.
Looks like this was added in 4f1f303, which points to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/is, which does not use -0.
So the proposal is to change the current code:
To the following:
The text was updated successfully, but these errors were encountered: