-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calling app.firestore().settings() from @firebase/testing breaks the app #3354
Comments
By the way, here's a workaround for anyone interested while this issue is not addressed: app.firestore()._settings.ignoreUndefinedProperties = true |
@gustavopch Thanks for reporting the issue and the workaround! The current behavior can definitely cause developer confusion because it's not straightforward to debug. We're currently thinking that we can either expose a getter for the settings object, or add an option to merge settings so that you don't have to use the workaround. I'm going to discuss with the team, and circle back to you soon. |
Just to circle back, we are planning to add a way to allow developers to merge their settings objects together when calling |
[REQUIRED] Describe your environment
[REQUIRED] Describe the problem
Steps to reproduce:
Calling
app.firestore().settings({ /* ... */ })
overrides the initial settings defined by@firebase/testing
'sinitializeTestApp
(as mentioned in this comment), so the tests stop working because it cannot connect to the local emulator anymore.Logs
Relevant Code:
The text was updated successfully, but these errors were encountered: