Use GoogleAppMeasurement main branch instead of release tag for CI #8426
Conversation
There was a problem hiding this comment.
LGTM.
The only question is if we should use main unconditionally or there are cases when we should keep using a specific version? If we don't know exact conditions we may want to have a way to specify either a branch or a tag or not change package manifest for a manual workflow trigger.
Generated by 🚫 Danger |
|
I'm proposing that we use I'll add a step to go/firi to verify that the Package.swift successfully loads after publishing the GoogleAppMeasurement tag. |
SGTM, though I would still prefer to reduce space for an error with some automatic validation. I'm thinking, maybe we can set up a pre-push hook in our local git repos to validate pushed tags, e.g. when a SPM tag push is detected in Firebase repo then SPM build is run locally before pushing. It's perhaps outside of scope of this PR, but something to consider for future. |
|
Agreed, there is more room to tighten up the process - especially on the development side. |
Use GoogleAppMeasurement main branch instead of release tag for CI. This enables us to use CI for release tagging without tagging the GoogleAppMeasurement repository until release and avoid needing to make last minute commits to the firebase repo to update to the new tag. b/194422721