Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Auth Context enabled Firestore triggers #184

Merged
merged 15 commits into from
Apr 8, 2024

Conversation

exaby73
Copy link
Contributor

@exaby73 exaby73 commented Mar 18, 2024

No description provided.

@exaby73 exaby73 marked this pull request as ready for review March 19, 2024 23:15
Copy link
Member

@pr-Mais pr-Mais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we just need some unit tests if feasible.

@blidd-google blidd-google self-requested a review April 5, 2024 03:20
Copy link
Collaborator

@blidd-google blidd-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except nit re: naming

@blidd-google blidd-google merged commit db7ad30 into main Apr 8, 2024
10 checks passed
@exaby73 exaby73 deleted the feat/auth-context branch April 9, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants