Skip to content

[FDL] Remove firebase-dynamic-links module #7094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jun 30, 2025

Removing deprecated firebase-dynamic-links SDK as the FDL service is being turned down in August 2025

Copy link
Contributor

Firebase AI Mock Responses Check ⚠️

A newer major version of the mock responses for Firebase AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v14.2

Copy link
Contributor

github-actions bot commented Jun 30, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @rlazo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request removes the firebase-dynamic-links module as the Firebase Dynamic Links service is being shut down in August 2025. This change involves removing the module from the subprojects configuration.

Highlights

  • Removal: Removes the deprecated firebase-dynamic-links module.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the deprecated firebase-dynamic-links module. The review suggests removing the firebase-dynamic-links module in addition to the firebase-dynamic-links:ktx subproject to fully complete the removal.

@rlazo rlazo changed the title Remove firebase-dynamic-links module [FDL] Remove firebase-dynamic-links module Jun 30, 2025
Copy link
Contributor

github-actions bot commented Jun 30, 2025

Test Results

 1 017 files  +   967   1 017 suites  +967   35m 2s ⏱️ + 33m 53s
 5 871 tests + 5 795   5 849 ✅ + 5 773  21 💤 +21  1 ❌ +1 
11 458 runs  +11 290  11 415 ✅ +11 247  42 💤 +42  1 ❌ +1 

For more details on these failures, see this check.

Results for commit b90c750. ± Comparison against base commit 2bfc0a5.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.22% (2bfc0a5) to 50.16% (4b1adbb) by -0.05%.

    FilenameBase (2bfc0a5)Merge (4b1adbb)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%
    DefaultPersistenceManager.java75.73%74.76%-0.97%
  • firebase-messaging

    Overall coverage changed from 84.02% (2bfc0a5) to 84.13% (4b1adbb) by +0.11%.

    FilenameBase (2bfc0a5)Merge (4b1adbb)Diff
    Metadata.java36.51%41.27%+4.76%
  • firebase-storage

    Overall coverage changed from 83.96% (2bfc0a5) to 83.92% (4b1adbb) by -0.04%.

    FilenameBase (2bfc0a5)Merge (4b1adbb)Diff
    StreamDownloadTask.java88.89%88.41%-0.48%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HVaMOJTtCj.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (117,104 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Rmuo5OAkTw/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants