Skip to content

Fix: Workflow trigger updated to run only on PRs to main #7087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

Fix: Workflow trigger updated to run only on PRs to main #7087

merged 1 commit into from
Jun 27, 2025

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jun 26, 2025

The metalava-semver-check.yml workflow was previously configured to run on all pull requests. This change updates the trigger to only run on pull requests that target the main branch.

@google-labs-jules
Fix: Workflow trigger updated to run only on PRs to main
7d36679 
The metalava-semver-check.yml workflow was previously configured to run on all pull requests. This change updates the trigger to only run on pull requests that target the `main` branch.
@rlazo rlazo requested a review from emilypgoogle June 26, 2025 22:15
@gemini-code-assist Gemini Code Assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@rlazo rlazo requested review from davidmotson and mrober June 26, 2025 22:15
@github-actions GitHub Actions
Copy link
Contributor

Firebase AI Mock Responses Check ⚠️

A newer major version of the mock responses for Firebase AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v14.1

@github-actions GitHub Actions
Copy link
Contributor

Test Results

 1 058 files  +  904   1 058 suites  +904   35m 29s ⏱️ + 27m 35s
 5 985 tests +4 837   5 963 ✅ +4 816  22 💤 +21  0 ❌ ±0 
12 033 runs  +9 731  11 989 ✅ +9 689  44 💤 +42  0 ❌ ±0 

Results for commit 7d36679. ± Comparison against base commit be2b6ed.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (be2b6ed) and merge commit (c991fab).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/LIspCQxqMf.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (be2b6ed) to 75.72% (c991fab) by ?.

    68 individual files with coverage change

    FilenameBase (be2b6ed)Merge (c991fab)Diff
    AabUpdater.java?98.36%?
    AabUpdater_Factory.java?0.00%?
    ApkInstaller.java?100.00%?
    ApkInstaller_Factory.java?0.00%?
    ApkUpdater.java?92.63%?
    ApkUpdater_Factory.java?0.00%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppDistroComponent.java?0.00%?
    AppDistroComponent_MainModule_BindContentResolverFactory.java?0.00%?
    AppIconSource.java?84.62%?
    AppIconSource_Factory.java?100.00%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?71.58%?
    AutoValue_ImageUtils_ImageSize.java?35.00%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    DaggerAppDistroComponent.java?80.56%?
    DevModeDetector.java?9.09%?
    DevModeDetector_Factory.java?100.00%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?3.39%?
    FeedbackActivity_MembersInjector.java?0.00%?
    FeedbackSender.java?84.48%?
    FeedbackSender_Factory.java?0.00%?
    FeedbackTrigger.java?61.54%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?89.89%?
    FirebaseAppDistributionImpl_Factory.java?0.00%?
    FirebaseAppDistributionLifecycleNotifier.java?91.49%?
    FirebaseAppDistributionLifecycleNotifier_Factory.java?0.00%?
    FirebaseAppDistributionNotificationsManager.java?88.89%?
    FirebaseAppDistributionNotificationsManager_Factory.java?0.00%?
    FirebaseAppDistributionRegistrar.java?95.83%?
    FirebaseAppDistributionTesterApiClient.java?88.78%?
    FirebaseAppDistributionTesterApiClient_Factory.java?0.00%?
    HttpsUrlConnectionFactory.java?50.00%?
    HttpsUrlConnectionFactory_Factory.java?100.00%?
    ImageUtils.java?100.00%?
    InstallActivity.java?2.67%?
    LogWrapper.java?86.67%?
    NewReleaseFetcher.java?86.67%?
    NewReleaseFetcher_Factory.java?0.00%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?91.78%?
    ReleaseIdentifier_Factory.java?0.00%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?36.17%?
    ScreenshotTaker_Factory.java?0.00%?
    SequentialReference.java?100.00%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?100.00%?
    SignInStorage_Factory.java?0.00%?
    TakeScreenshotAndStartFeedbackActivity.java?0.00%?
    TakeScreenshotAndStartFeedbackActivity_MembersInjector.java?0.00%?
    TaskCache.java?100.00%?
    TaskCompletionSourceCache.java?72.41%?
    TaskUtils.java?77.50%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?90.09%?
    TesterApiHttpClient_Factory.java?0.00%?
    TesterSignInManager.java?89.41%?
    TesterSignInManager_Factory.java?0.00%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskCache.java?91.30%?
    UpdateTaskImpl.java?76.32%?

  • firebase-database

    Overall coverage changed from 50.16% (be2b6ed) to 50.21% (c991fab) by +0.04%.

    FilenameBase (be2b6ed)Merge (c991fab)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%

  • firebase-firestore

    Overall coverage changed from 45.77% (be2b6ed) to 45.78% (c991fab) by +0.00%.

    FilenameBase (be2b6ed)Merge (c991fab)Diff
    SetMutation.java94.44%97.22%+2.78%

  • firebase-storage

    Overall coverage changed from 84.33% (be2b6ed) to 84.04% (c991fab) by -0.29%.

    FilenameBase (be2b6ed)Merge (c991fab)Diff
    StorageException.java69.09%65.45%-3.64%
    StorageTask.java83.99%83.69%-0.30%
    UploadTask.java83.17%81.85%-1.32%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Njzx8LjX9O.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,592 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/BoRzXeG2Lg/index.html

@rlazo rlazo merged commit c12b5d1 into main Jun 27, 2025
268 of 270 checks passed
@rlazo rlazo deleted the update-workflow-trigger branch June 27, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmotson davidmotson davidmotson approved these changes

@emilypgoogle emilypgoogle Awaiting requested review from emilypgoogle

@mrober mrober Awaiting requested review from mrober

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @davidmotson