Skip to content

m166 mergeback #7083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

m166 mergeback #7083

merged 1 commit into from
Jun 26, 2025

Conversation

google-oss-bot
Copy link
Contributor

Auto-generated PR for cleaning up release m166

NO_RELEASE_CHANGE

@github-actions GitHub Actions
Copy link
Contributor

Firebase AI Mock Responses Check ⚠️

A newer major version of the mock responses for Firebase AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v14.1

@github-actions GitHub Actions
Copy link
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jun 26, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @google-oss-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request merges back changes related to version updates and associated fixes/features for the firebase-ai, firebase-dataconnect, firebase-messaging-directboot, and firebase-messaging libraries. The primary purpose is to update the library versions and reflect the corresponding changes in their respective changelogs.

Highlights

  • Version Updates: The firebase-ai, firebase-dataconnect, firebase-messaging-directboot, and firebase-messaging libraries have had their versions incremented.
  • Changelog Updates: Changelog files for the affected libraries have been updated to reflect the new versions and any associated changes.
  • firebase-ai changes: The totalBillableCharacters field is deprecated, and support for extra schema properties has been added.
  • firebase-dataconnect changes: A fix has been applied to address an occasional NullPointerException.
  • firebase-messaging changes: A NamedThreadFactory has been added to WithinAppServiceConnection's service connection Executor.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jun 26, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to be a routine merge-back operation, primarily updating version numbers in gradle.properties files and corresponding CHANGELOG.md entries across several Firebase modules (firebase-ai, firebase-dataconnect, firebase-messaging-directboot, firebase-messaging). The changes are consistent with standard release procedures and do not introduce any functional code modifications. Based on the specified review criteria and severity levels (medium, high, critical), no issues were identified.

@rlazo rlazo requested a review from VinayGuthal June 26, 2025 18:36
@github-actions GitHub Actions
Copy link
Contributor

Test Results

  154 files   -   885    154 suites   - 885   7m 53s ⏱️ - 28m 16s
1 148 tests  - 4 837  1 147 ✅  - 4 815  1 💤  - 21  0 ❌  - 1 
2 302 runs   - 9 407  2 300 ✅  - 9 364  2 💤  - 42  0 ❌  - 1 

Results for commit d239ae6. ± Comparison against base commit 4d6e2db.

This pull request removes 4837 tests. 
com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldAddCookieOnPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldDropCookieOnMixedPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost
…

@google-oss-bot
Copy link
Contributor Author

Coverage Report 1

Affected Products

  • firebase-dataconnect

    Overall coverage changed from ? (4d6e2db) to 13.69% (83e6138) by ?.

    62 individual files with coverage change

    FilenameBase (4d6e2db)Merge (83e6138)Diff
    AlphanumericStringUtil.kt?0.00%?
    AnyValue.kt?0.00%?
    AnyValueSerializer.kt?0.00%?
    Comparisons.kt?0.00%?
    ConnectorConfig.kt?33.33%?
    CoroutineExceptionHandler.kt?50.00%?
    DataConnectAppCheck.kt?71.43%?
    DataConnectAuth.kt?71.43%?
    DataConnectCredentialsTokenManager.kt?31.41%?
    DataConnectException.kt?0.00%?
    DataConnectGrpcClient.kt?0.00%?
    DataConnectGrpcMetadata.kt?65.82%?
    DataConnectGrpcRPCs.kt?0.00%?
    DataConnectOperationException.kt?0.00%?
    DataConnectOperationFailureResponse.kt?0.00%?
    DataConnectOperationFailureResponseImpl.kt?0.00%?
    DataConnectPathSegment.kt?0.00%?
    DataConnectSettings.kt?33.33%?
    DataConnectUntypedData.kt?0.00%?
    DataConnectUntypedVariables.kt?0.00%?
    Emitters.kt?100.00%?
    ExperimentalFirebaseDataConnect.kt?0.00%?
    FirebaseDataConnect.kt?50.00%?
    FirebaseDataConnectFactory.kt?29.17%?
    FirebaseDataConnectImpl.kt?34.11%?
    FirebaseDataConnectRegistrar.kt?100.00%?
    GeneratedConnector.kt?0.00%?
    GeneratedMutation.kt?0.00%?
    GeneratedOperation.kt?0.00%?
    GeneratedQuery.kt?0.00%?
    Globals.kt?0.00%?
    JavaTimeLocalDateSerializer.kt?0.00%?
    KotlinxDatetimeLocalDateSerializer.kt?0.00%?
    LiveQueries.kt?0.00%?
    LiveQuery.kt?0.00%?
    LocalDate.kt?0.00%?
    LocalDateSerializer.kt?0.00%?
    Logger.kt?73.68%?
    LogLevel.kt?72.73%?
    MutationRef.kt?0.00%?
    MutationRefImpl.kt?12.50%?
    NullableReference.kt?0.00%?
    NullOutputStream.kt?0.00%?
    OperationRef.kt?0.00%?
    OperationRefImpl.kt?20.45%?
    OptionalVariable.kt?0.00%?
    ProtoStructDecoder.kt?0.00%?
    ProtoStructEncoder.kt?0.00%?
    ProtoUtil.kt?0.00%?
    QueryManager.kt?0.00%?
    QueryRef.kt?0.00%?
    QueryRefImpl.kt?14.08%?
    QuerySubscription.kt?0.00%?
    QuerySubscriptionImpl.kt?0.00%?
    QuerySubscriptionInternal.kt?0.00%?
    ReferenceCounted.kt?0.00%?
    RegisteredDataDeserialzer.kt?0.00%?
    SafeCollector.common.kt?66.67%?
    SequencedReference.kt?0.00%?
    SuspendingLazy.kt?0.00%?
    TimestampSerializer.kt?0.00%?
    UUIDSerializer.kt?0.00%?

  • firebase-messaging

    Overall coverage changed from ? (4d6e2db) to 84.02% (83e6138) by ?.

    42 individual files with coverage change

    FilenameBase (4d6e2db)Merge (83e6138)Diff
    AutoProtoEncoderDoNotUseEncoder.java?98.17%?
    ByteStreams.java?59.72%?
    CommonNotificationBuilder.java?90.29%?
    Constants.java?92.86%?
    DisplayNotification.java?89.66%?
    EnhancedIntentService.java?76.60%?
    ExecutorFactory.java?0.00%?
    FcmBroadcastProcessor.java?92.45%?
    FcmExecutors.java?80.00%?
    FcmLifecycleCallbacks.java?86.67%?
    FirebaseInstanceIdReceiver.java?72.73%?
    FirebaseMessaging.java?76.00%?
    FirebaseMessagingRegistrar.java?100.00%?
    FirebaseMessagingService.java?94.52%?
    GmsRpc.java?83.52%?
    ImageDownload.java?93.33%?
    Messaging.kt?14.29%?
    MessagingAnalytics.java?82.87%?
    MessagingClientEvent.java?95.41%?
    MessagingClientEventExtension.java?76.47%?
    Metadata.java?36.51%?
    NotificationParams.java?98.71%?
    PoolableExecutors.java?29.17%?
    ProtoEncoderDoNotUse.java?50.00%?
    ProxyNotificationInitializer.java?93.75%?
    ProxyNotificationPreferences.java?95.83%?
    RemoteMessage.java?95.48%?
    RemoteMessageCreator.java?88.89%?
    RequestDeduplicator.java?90.00%?
    SendException.java?100.00%?
    ServiceStarter.java?87.50%?
    SharedPreferencesQueue.java?98.65%?
    Store.java?74.19%?
    SyncTask.java?70.67%?
    ThreadPriority.java?100.00%?
    TopicOperation.java?73.33%?
    TopicsStore.java?100.00%?
    TopicsSubscriber.java?88.70%?
    TopicsSyncTask.java?49.33%?
    WakeLockHolder.java?95.92%?
    WithinAppServiceBinder.java?90.91%?
    WithinAppServiceConnection.java?77.38%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/fk41DOay8u.html

@google-oss-bot
Copy link
Contributor Author

Size Report 1

Affected Products

  • firebase-ai

    TypeBase (4d6e2db)Merge (83e6138)Diff
    aar829 kB829 kB-5 B (-0.0%)

  • firebase-dataconnect

    TypeBase (4d6e2db)Merge (83e6138)Diff
    aar704 kB704 kB-2 B (-0.0%)

  • firebase-messaging

    TypeBase (4d6e2db)Merge (83e6138)Diff
    aar149 kB149 kB+6 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/JQcfcByx44.html

@google-oss-bot
Copy link
Contributor Author

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (83e6138) and the base commit (4d6e2db) are not available.

No macrobenchmark data found for the base commit (4d6e2db). Analysis for the CI merge commit (83e6138) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zL5n4X5rYY/index.html

@rlazo rlazo merged commit be2b6ed into main Jun 26, 2025
60 checks passed
@rlazo rlazo deleted the releases/m166.mergeback branch June 26, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@rlazo rlazo rlazo approved these changes

@VinayGuthal VinayGuthal VinayGuthal approved these changes

Assignees

@rlazo rlazo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@google-oss-bot @rlazo @VinayGuthal