Update ActionCodeSettings to support link_domain #884
+50
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errkk
approved these changes
Jun 3, 2025
|
@lahirumaramba @pashanka see here re: #883. In my org we're currently relying on this via a fork and would be great to get into main release. |
firebase_admin/_auth_utils.py
Outdated
| @@ -328,6 +328,15 @@ def __init__(self, message, cause, http_response): | |||
| exceptions.InvalidArgumentError.__init__(self, message, cause, http_response) | |||
|
|
|||
|
|
|||
| class InvalidHostingLinkDomainError(exceptions.InvalidArgumentError): | |||
| """Hosting link domain in ActionCodeSettings is not authorized.""" | |||
There was a problem hiding this comment.
Can you update both msgs to be
"Hosting link domain in ActionCodeSettings is not authorized or is not owned by the current project."? to be more aligned with node SDK. See: https://github.com/firebase/firebase-admin-node/blob/26b884f70300ef8e3213dfbbd72351ce7f68c695/src/utils/error.ts#L510
There was a problem hiding this comment.
Certainly, appreciate you putting eyes on this. Updated in bc7fcfc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
Firebase Dynamic Links will stop working August 25th 2025.
Migration instructions indicate that to use a custom domain one should update usage of
ActionCodeSettingsto uselinkDomain, see also in the Firebase Admin docs.We currently depend upon
generate_sign_in_with_email_linkto generate email links,firebase-admin-pythonhasn't been updated withlink_domainand currently only supportsdynamic_link_domain,firebase-admin-nodehas been updated with support forlinkDomainso I assume this should be officially supported, please let me know if this is not the case.See #883.
This PR updates
ActionCodeSettingsto acceptlink_domainand updatesencode_action_code_settingsto handlelink_domainwhen constructing request payload. I have also added definition for newInvalidHostingLinkDomainErrorerror.