Implement SendEach, SendEachDryRun, SendEachForMulticast,
#544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahirumaramba
approved these changes
Mar 23, 2023
|
Please make sure that this branch is based off of |
|
`SendEachForMulticastDryRun`
1. Add `SendEach`, `SendEachDryRun`, `SendEachForMulticast`,
`SendEachForMulticastDryRun`
2. Deprecate `SendAll`, `SendAllDryRun`, `SendMulticast`,
`SendMulticastDryRun`
`SendEach` vs `SendAll`
1. `SendEach` sends one HTTP request to V1 Send endpoint for each
message in the array.
`SendAll` sends only one HTTP request to V1 Batch Send endpoint
to send all messages in the array.
2. `SendEach` calls fcmClient.Send to send each message
and constructs a SendResponse with the returned message id or error.
`SendEach` uses sync.WaitGroup to execute all fcmClient.Send calls
asynchronously and wait for all of them to complete and construct a
BatchResponse with all SendResponses.
Therefore, unlike `SendAll`, `SendEach` does not always returns
an error for a total failure. It can also return a `BatchResponse`
with only errors in it.
`SendEachForMulticast` calls `SendEach` under the hood.
9d24429
to
4ffa38f
Compare
Doris-Ge
added a commit
that referenced
this pull request
Apr 5, 2023
`SendEachForMulticastDryRun`
1. Add `SendEach`, `SendEachDryRun`, `SendEachForMulticast`,
`SendEachForMulticastDryRun`
2. Deprecate `SendAll`, `SendAllDryRun`, `SendMulticast`,
`SendMulticastDryRun`
`SendEach` vs `SendAll`
1. `SendEach` sends one HTTP request to V1 Send endpoint for each
message in the array.
`SendAll` sends only one HTTP request to V1 Batch Send endpoint
to send all messages in the array.
2. `SendEach` calls fcmClient.Send to send each message
and constructs a SendResponse with the returned message id or error.
`SendEach` uses sync.WaitGroup to execute all fcmClient.Send calls
asynchronously and wait for all of them to complete and construct a
BatchResponse with all SendResponses.
Therefore, unlike `SendAll`, `SendEach` does not always returns
an error for a total failure. It can also return a `BatchResponse`
with only errors in it.
`SendEachForMulticast` calls `SendEach` under the hood.
Doris-Ge
added a commit
that referenced
this pull request
Apr 21, 2023
* Implement `SendEach`, `SendEachDryRun`, `SendEachForMulticast`, (#544) `SendEachForMulticastDryRun` 1. Add `SendEach`, `SendEachDryRun`, `SendEachForMulticast`, `SendEachForMulticastDryRun` 2. Deprecate `SendAll`, `SendAllDryRun`, `SendMulticast`, `SendMulticastDryRun` `SendEach` vs `SendAll` 1. `SendEach` sends one HTTP request to V1 Send endpoint for each message in the array. `SendAll` sends only one HTTP request to V1 Batch Send endpoint to send all messages in the array. 2. `SendEach` calls fcmClient.Send to send each message and constructs a SendResponse with the returned message id or error. `SendEach` uses sync.WaitGroup to execute all fcmClient.Send calls asynchronously and wait for all of them to complete and construct a BatchResponse with all SendResponses. Therefore, unlike `SendAll`, `SendEach` does not always returns an error for a total failure. It can also return a `BatchResponse` with only errors in it. `SendEachForMulticast` calls `SendEach` under the hood. * Add integration tests for `SendEach` and `SendEachForMulticast` (#550) * Avoid using "-- i.e." in the function comments * Remove all backticks in messaging_batch.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SendEachForMulticastDryRunSendEach,SendEachDryRun,SendEachForMulticast,SendEachForMulticastDryRunSendAll,SendAllDryRun,SendMulticast,SendMulticastDryRunSendEachvsSendAllSendEachsends one HTTP request to V1 Send endpoint for each message in the array.SendAllsends only one HTTP request to V1 Batch Send endpoint to send all messages in the array.SendEachcalls fcmClient.Send to send each message and constructs a SendResponse with the returned message id or error.SendEachuses sync.WaitGroup to execute all fcmClient.Send calls asynchronously and wait for all of them to complete and construct a BatchResponse with all SendResponses. Therefore, unlikeSendAll,SendEachdoes not always returns an error for a total failure. It can also return aBatchResponsewith only errors in it.SendEachForMulticastcallsSendEachunder the hood.Will send the integration tests in another PR.