Skip to content

fix(board): Update variant.cpp for senseBox MCU-S2 ESP32-S2 #11532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 2, 2025
Merged

fix(board): Update variant.cpp for senseBox MCU-S2 ESP32-S2 #11532

merged 5 commits into from
Jul 2, 2025
+331 −28

Conversation

PaulaScharf
Copy link
Contributor

Description of Change

Updated variant.cpp for senseBox MCU-S2 ESP32-S2. More specifically the partition on the board now changes on button press and UART is only enabled for board versions without PSRAM.

Tests scenarios

Tested on senseBox MCU-S2 ESP32-S2.

@PaulaScharf PaulaScharf requested a review from P-R-O-C-H-Y as a code owner July 1, 2025 09:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello PaulaScharf, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 031a9fa

P-R-O-C-H-Y
P-R-O-C-H-Y reviewed Jul 2, 2025
View reviewed changes
P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Jul 2, 2025
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just add to description info about the APOTA :)

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Awaiting Response awaiting a response from the author label Jul 2, 2025
@P-R-O-C-H-Y
Copy link
Member

P-R-O-C-H-Y commented Jul 2, 2025 •
edited
Loading

@PaulaScharf PTAL on my comment above + fix the precommit errors: https://github.com/espressif/arduino-esp32/actions/runs/16025222516/job/45211382735?pr=11532#step:9:29

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Awaiting Response awaiting a response from the author labels Jul 2, 2025
@me-no-dev
Copy link
Member

Some typos: https://github.com/espressif/arduino-esp32/actions/runs/16025222516/job/45211382735?pr=11532#step:9:29

@PaulaScharf
Copy link
Contributor Author

ok, I translated a lot of comments. I hope its fine now

@me-no-dev me-no-dev merged commit 12e881b into espressif:master Jul 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PaulaScharf @P-R-O-C-H-Y @me-no-dev