Write to manifest #439
Merged
Write to manifest #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/elixir_script/passes/output.ex
Outdated
| @@ -27,8 +28,13 @@ defmodule ElixirScript.Output do | |||
| {module, name, path, import_path} | |||
| end) | |||
|
|
|||
| modules | |||
| |> create_modules(opts, js_modules) | |||
|
|
|||
There was a problem hiding this comment.
There should be no more than 1 consecutive blank lines.
| @@ -94,7 +94,9 @@ defmodule ElixirScript.FindUsedModules do | |||
|
|
|||
| functions = Enum.map(first_implementation_functions, fn { name, _, _, _} -> name end) | |||
|
|
|||
| ModuleState.put_module(pid, module, %{protocol: true, impls: impls, functions: functions}) | |||
| module_info = Map.merge(module_info, %{protocol: true, impls: impls, functions: functions}) | |||
There was a problem hiding this comment.
Line is too long (max is 80, was 95).
| @@ -7,7 +7,7 @@ defmodule ElixirScript.Beam do | |||
| For protocols, this will return a list of | |||
| all the protocol implementations | |||
| """ | |||
| @spec debug_info(atom | bitstring) :: {:ok | :error, map | binary} | |||
| @spec debug_info(atom | bitstring) :: {:ok, map} | {:ok, atom, map, list} | {:error, binary} | |||
There was a problem hiding this comment.
Line is too long (max is 80, was 94).
.credo.exs
Outdated
| @@ -61,7 +61,7 @@ | |||
|
|
|||
| {Credo.Check.Readability.FunctionNames}, | |||
| {Credo.Check.Readability.LargeNumbers}, | |||
| {Credo.Check.Readability.MaxLineLength, priority: :low, max_length: 80}, | |||
| {Credo.Check.Readability.MaxLineLength, priority: :low, max_length: 80, ignore_specs: true}, | |||
There was a problem hiding this comment.
Line is too long (max is 80, was 100).
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/elixirscript/elixirscript/pulls/439. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #435
fixes #436