Skip to content

fix: fix float in dynamic Document creation #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2024
Merged

fix: fix float in dynamic Document creation #1877

merged 1 commit into from
Mar 18, 2024

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Mar 18, 2024

No description provided.

@JoanFM JoanFM changed the title fix: fix float in doc fix: fix float in dynamic Document creation Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.69%. Comparing base (f71a5e6) to head (7730bbf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1877   +/-   ##
=======================================
  Coverage   84.68%   84.69%           
=======================================
  Files         136      136           
  Lines        9261     9263    +2     
=======================================
+ Hits         7843     7845    +2     
  Misses       1418     1418           
Flag Coverage Δ
docarray 84.69% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoanFM JoanFM force-pushed the fix-float-dynamic branch from 8613704 to 5d1980f Compare March 18, 2024 09:56
@JoanFM JoanFM force-pushed the fix-float-dynamic branch from 5d1980f to 7730bbf Compare March 18, 2024 10:21
@JoanFM JoanFM marked this pull request as ready for review March 18, 2024 10:30
@JoanFM JoanFM merged commit febbdc4 into main Mar 18, 2024
@JoanFM JoanFM deleted the fix-float-dynamic branch March 18, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant