Skip to content

fix: fix DocList schema when using Pydantic V2 #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Mar 21, 2025
Merged

fix: fix DocList schema when using Pydantic V2 #1876

merged 31 commits into from
Mar 21, 2025

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Mar 8, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Mar 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.42254% with 21 lines in your changes missing coverage. Please review.

Project coverage is 61.08%. Comparing base (82d7cee) to head (0f27ffa).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
docarray/__init__.py 56.66% 13 Missing ⚠️
docarray/utils/create_dynamic_doc_class.py 0.00% 5 Missing ⚠️
docarray/array/any_array.py 92.30% 1 Missing ⚠️
docarray/array/doc_list/doc_list.py 88.88% 1 Missing ⚠️
docarray/array/doc_vec/doc_vec.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1876       +/-   ##
===========================================
+ Coverage   29.01%   61.08%   +32.06%     
===========================================
  Files         136      137        +1     
  Lines        9468     9628      +160     
===========================================
+ Hits         2747     5881     +3134     
+ Misses       6721     3747     -2974
Flag Coverage Δ
docarray 61.08% <70.42%> (+32.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoanFM JoanFM force-pushed the try-fix-doclist-schema branch 3 times, most recently from 12cd670 to 1f35aca Compare March 11, 2024 10:34
@JoanFM JoanFM force-pushed the try-fix-doclist-schema branch from 1f35aca to febea8d Compare March 11, 2024 10:36
@JoanFM JoanFM force-pushed the try-fix-doclist-schema branch 3 times, most recently from e8c3334 to dfb3c85 Compare March 11, 2024 17:53
@JoanFM JoanFM force-pushed the try-fix-doclist-schema branch from dfb3c85 to a07919d Compare March 12, 2024 08:44
@JoanFM JoanFM linked an issue Mar 12, 2024 that may be closed by this pull request
Bug: Jsonschema of DocList not correct #1521
Closed
@JoanFM JoanFM marked this pull request as ready for review March 12, 2024 15:25
@JoanFM JoanFM changed the title fix: try to fix doclist schema fix: Fix DocList schema when using Pydantic V2 Mar 12, 2024
@JoanFM JoanFM changed the title fix: Fix DocList schema when using Pydantic V2 fix: fix DocList schema when using Pydantic V2 Mar 12, 2024
@JoanFM JoanFM force-pushed the try-fix-doclist-schema branch from c652ed2 to 8a57030 Compare March 12, 2024 15:32
@JoanFM JoanFM force-pushed the try-fix-doclist-schema branch from 4990a0f to 5ff2f68 Compare March 12, 2025 17:04
@JoanFM JoanFM force-pushed the try-fix-doclist-schema branch from 0f27ffa to 4f42c0b Compare March 13, 2025 14:54
@JoanFM JoanFM closed this Mar 17, 2025
@JoanFM JoanFM reopened this Mar 17, 2025
@JoanFM JoanFM closed this Mar 17, 2025
@JoanFM JoanFM reopened this Mar 17, 2025
@github-actions github-actions bot added size/l and removed size/m labels Mar 17, 2025
@JoanFM JoanFM closed this Mar 18, 2025
@JoanFM JoanFM reopened this Mar 18, 2025
@JoanFM JoanFM closed this Mar 18, 2025
@JoanFM JoanFM reopened this Mar 18, 2025
@JoanFM JoanFM merged commit d98acb7 into main Mar 21, 2025
69 of 73 checks passed
@JoanFM JoanFM deleted the try-fix-doclist-schema branch March 21, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/cicd area/core area/entrypoint area/housekeeping area/testing area/typing component/array size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Jsonschema of DocList not correct
1 participant
@JoanFM