Skip to content

docs: add code review to contributing.md #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Feb 8, 2024

No description provided.

@github-actions github-actions bot added the size/s label Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

📝 Docs are deployed on https://ft-add-code-review-to-contributing--jina-docs.netlify.app 🎉

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5037635) 85.06% compared to head (75efe89) 75.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1853      +/-   ##
==========================================
- Coverage   85.06%   75.43%   -9.64%     
==========================================
  Files         136      136              
  Lines        9260     9260              
==========================================
- Hits         7877     6985     -892     
- Misses       1383     2275     +892     
Flag Coverage Δ
docarray 75.43% <ø> (-9.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoanFM JoanFM merged commit 8da50c9 into main Feb 8, 2024
@JoanFM JoanFM deleted the add-code-review-to-contributing branch February 8, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant