Skip to content

fix: docstring tests with pydantic v2 #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 2, 2023
Merged

fix: docstring tests with pydantic v2 #1816

merged 4 commits into from
Oct 2, 2023

Conversation

samsja
Copy link
Member

@samsja samsja commented Oct 2, 2023

No description provided.

@samsja samsja requested a review from JoanFM October 2, 2023 08:09
@samsja samsja marked this pull request as ready for review October 2, 2023 08:10
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

📝 Docs are deployed on https://ft-fix-docs-pydantic-v2--jina-docs.netlify.app 🎉

@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9a6b1e6) 84.61% compared to head (37ce03b) 83.94%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1816      +/-   ##
==========================================
- Coverage   84.61%   83.94%   -0.68%     
==========================================
  Files         135      135              
  Lines        9005     9006       +1     
==========================================
- Hits         7620     7560      -60     
- Misses       1385     1446      +61
Flag Coverage Δ
docarray 83.94% <ø> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
docarray/array/doc_list/doc_list.py 87.30% <ø> (ø)
docarray/documents/audio.py 94.87% <ø> (ø)
docarray/documents/image.py 92.30% <ø> (ø)
docarray/documents/mesh/mesh_3d.py 100.00% <ø> (ø)
docarray/documents/point_cloud/point_cloud_3d.py 94.59% <ø> (ø)
docarray/documents/text.py 97.50% <ø> (ø)
docarray/documents/video.py 95.12% <ø> (ø)
docarray/typing/bytes/audio_bytes.py 100.00% <ø> (ø)
docarray/typing/tensor/audio/audio_ndarray.py 100.00% <ø> (ø)
docarray/typing/tensor/audio/audio_torch_tensor.py 100.00% <ø> (ø)
... and 6 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samsja samsja merged commit c2b08fa into main Oct 2, 2023
@samsja samsja deleted the fix-docs-pydantic-v2 branch October 2, 2023 08:33
@JoanFM JoanFM mentioned this pull request Oct 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM approved these changes

Assignees
No one assigned
Labels
area/core area/docs area/testing area/typing component/array size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsja @JoanFM