Skip to content

fix: validate before #1806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 27, 2023
Merged

fix: validate before #1806

merged 10 commits into from
Sep 27, 2023

Conversation

samsja
Copy link
Member

@samsja samsja commented Sep 27, 2023

Context

Allow to do ImageDoc('url') behavior for all of the predefined document.

Signed-off-by: samsja <[email protected]>
Signed-off-by: samsja <[email protected]>
Signed-off-by: samsja <[email protected]>
Signed-off-by: samsja <[email protected]>
Signed-off-by: samsja <[email protected]>
Signed-off-by: samsja <[email protected]>
@samsja samsja marked this pull request as ready for review September 27, 2023 09:03
@samsja samsja linked an issue Sep 27, 2023 that may be closed by this pull request
@samsja samsja closed this Sep 27, 2023
@samsja samsja reopened this Sep 27, 2023
Signed-off-by: samsja <[email protected]>
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (dce3907) 84.80% compared to head (aaec7fe) 84.20%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1806      +/-   ##
==========================================
- Coverage   84.80%   84.20%   -0.61%     
==========================================
  Files         135      135              
  Lines        8906     8969      +63     
==========================================
- Hits         7553     7552       -1     
- Misses       1353     1417      +64     
Flag Coverage Δ
docarray 84.20% <94.68%> (-0.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
docarray/documents/audio.py 94.87% <100.00%> (+2.01%) ⬆️
docarray/documents/point_cloud/point_cloud_3d.py 94.59% <100.00%> (+2.28%) ⬆️
docarray/documents/video.py 95.12% <100.00%> (+1.78%) ⬆️
docarray/typing/tensor/ndarray.py 87.36% <ø> (+0.91%) ⬆️
docarray/documents/image.py 92.30% <94.11%> (+3.02%) ⬆️
docarray/documents/text.py 95.00% <93.33%> (-1.67%) ⬇️
docarray/documents/mesh/mesh_3d.py 88.88% <80.00%> (-11.12%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

📝 Docs are deployed on https://ft-fix-validate-before--jina-docs.netlify.app 🎉

@JoanFM JoanFM merged commit 26d776d into main Sep 27, 2023
@JoanFM JoanFM deleted the fix-validate-before branch September 27, 2023 15:59
@JoanFM JoanFM mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pydantic v2] Validation with default value is not working
2 participants