Skip to content

fix: milvus connection para missing #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

lvzii
Copy link
Contributor

@lvzii lvzii commented Sep 21, 2023

missing parameter port

missing parameter port

Signed-off-by: lvzi <[email protected]>
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3718a74) 84.81% compared to head (24e9562) 84.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1802   +/-   ##
=======================================
  Coverage   84.81%   84.81%           
=======================================
  Files         135      135           
  Lines        8904     8904           
=======================================
  Hits         7552     7552           
  Misses       1352     1352           
Flag Coverage Δ
docarray 84.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
docarray/index/backends/milvus.py 90.76% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoanFM
Copy link
Member

JoanFM commented Sep 21, 2023

Thank you very much for the fix!

@JoanFM JoanFM merged commit 0148e99 into docarray:main Sep 21, 2023
@JoanFM JoanFM mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants