Skip to content

feat: enable dynamic doc with Pydantic v2 #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 28, 2023
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Sep 18, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (92de15e) 84.43% compared to head (d488a50) 84.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1795      +/-   ##
==========================================
+ Coverage   84.43%   84.60%   +0.17%     
==========================================
  Files         135      135              
  Lines        8979     9004      +25     
==========================================
+ Hits         7581     7618      +37     
+ Misses       1398     1386      -12     
Flag Coverage Δ
docarray 84.60% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
docarray/utils/create_dynamic_doc_class.py 87.50% <100.00%> (+4.00%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Joan Fontanals Martinez <[email protected]>
@JoanFM JoanFM force-pushed the pydantic-v2-dynamic-schema branch from 56734b5 to 12a8747 Compare September 18, 2023 11:29
@JoanFM JoanFM force-pushed the pydantic-v2-dynamic-schema branch 3 times, most recently from 3bd2831 to 46ffc62 Compare September 28, 2023 08:15
Signed-off-by: Joan Fontanals Martinez <[email protected]>
@JoanFM JoanFM force-pushed the pydantic-v2-dynamic-schema branch from 46ffc62 to f208ccf Compare September 28, 2023 09:04
@JoanFM JoanFM force-pushed the pydantic-v2-dynamic-schema branch from 351b293 to 6985ffb Compare September 28, 2023 15:38
…ntic-v2-dynamic-schema

Signed-off-by: Joan Fontanals Martinez <[email protected]>
@JoanFM JoanFM force-pushed the pydantic-v2-dynamic-schema branch 2 times, most recently from de49257 to 8e8833a Compare September 28, 2023 16:18
Signed-off-by: Joan Fontanals Martinez <[email protected]>
@JoanFM JoanFM force-pushed the pydantic-v2-dynamic-schema branch from 8e8833a to dbb7c69 Compare September 28, 2023 16:19
@github-actions
Copy link

📝 Docs are deployed on https://ft-pydantic-v2-dynamic-schema--jina-docs.netlify.app 🎉

@JoanFM JoanFM marked this pull request as ready for review September 28, 2023 17:37
@JoanFM JoanFM merged commit 83d2236 into main Sep 28, 2023
@JoanFM JoanFM deleted the pydantic-v2-dynamic-schema branch September 28, 2023 17:37
@JoanFM JoanFM mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pydantic 2] create pydantic model from schema
1 participant