Skip to content

feat: remove JAC #1791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2023
Merged

feat: remove JAC #1791

merged 4 commits into from
Sep 18, 2023

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Sep 15, 2023

Since Jina AI Cloud is going to be stopped, JACStore will not work anymore, this PR removes it

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.66% ⚠️

Comparison is base (d0b9990) 85.46% compared to head (2c0e2e0) 84.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1791      +/-   ##
==========================================
- Coverage   85.46%   84.80%   -0.66%     
==========================================
  Files         136      135       -1     
  Lines        9046     8899     -147     
==========================================
- Hits         7731     7547     -184     
- Misses       1315     1352      +37     
Flag Coverage Δ
docarray 84.80% <100.00%> (-0.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
docarray/utils/_internal/misc.py 65.57% <ø> (ø)
docarray/array/doc_list/pushpull.py 91.66% <100.00%> (-0.53%) ⬇️
docarray/store/__init__.py 94.44% <100.00%> (+3.53%) ⬆️
docarray/store/abstract_doc_store.py 76.66% <100.00%> (ø)
docarray/store/file.py 82.43% <100.00%> (+0.85%) ⬆️
docarray/store/s3.py 86.17% <100.00%> (+0.75%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoanFM JoanFM force-pushed the feat-remove-jac-store branch from b42de4e to 964bbc1 Compare September 15, 2023 16:41
Signed-off-by: Joan Fontanals Martinez <[email protected]>
@github-actions
Copy link

📝 Docs are deployed on https://ft-feat-remove-jac-store--jina-docs.netlify.app 🎉

@JoanFM JoanFM requested review from samsja and nan-wang September 18, 2023 10:07
@JoanFM JoanFM merged commit 8fba9e4 into main Sep 18, 2023
@JoanFM JoanFM deleted the feat-remove-jac-store branch September 18, 2023 10:35
@JoanFM JoanFM mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants