fix: relax the schema check in update mixin #1755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alaeddine Abdessalem <[email protected]>
|
📝 Docs are deployed on https://ft-fix-update-mixin-relax-check--jina-docs.netlify.app 🎉 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1755 +/- ##
==========================================
+ Coverage 83.60% 84.99% +1.39%
==========================================
Files 134 134
Lines 8842 8844 +2
==========================================
+ Hits 7392 7517 +125
+ Misses 1450 1327 -123
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
2 tasks
samsja
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current schema check in the UpdateMixin is strict and does not allow updating in cases the schema of both documents are similar but not exactly the same.
For instance, if are dynamically generated schemas but have the same fields and field types, the check will still evaluate to false and it would not be possible to update the documents.
This case happens in Jina's reduce procedure where the schemas are retrieved and generated dynamically.
This PR relaxes the check and allows checking whether the fields of the schemas are similar instead.