Skip to content

fix: fix readme test #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2023
Merged

fix: fix readme test #1746

merged 1 commit into from
Aug 7, 2023

Conversation

samsja
Copy link
Member

@samsja samsja commented Aug 7, 2023

Context

will fix broken ci and test coverage on main

@JohannesMessner
Copy link
Member

Not sure to understand how this fixes it

Signed-off-by: samsja <[email protected]>
@samsja
Copy link
Member Author

samsja commented Aug 7, 2023

Not sure to understand how this fixes it

basically the test is falling bc we try to run the jina part of the readme without installing jina. I just added jina to the ignore argument like we do with fastapi and all. So it should fix it (hopefully)

@JohannesMessner
Copy link
Member

I see, that makes sense.
But the readme alone can't crash our coverage from ~80% to ~30%, right?

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

📝 Docs are deployed on https://ft-fix-test--jina-docs.netlify.app 🎉

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: +54.93% 🎉

Comparison is base (a39c4f9) 30.06% compared to head (f934258) 84.99%.

❗ Current head f934258 differs from pull request most recent head 2d65412. Consider uploading reports for the commit 2d65412 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1746       +/-   ##
===========================================
+ Coverage   30.06%   84.99%   +54.93%     
===========================================
  Files         133      134        +1     
  Lines        8731     8838      +107     
===========================================
+ Hits         2625     7512     +4887     
+ Misses       6106     1326     -4780     
Flag Coverage Δ
docarray 84.99% <ø> (+54.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 110 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samsja
Copy link
Member Author

samsja commented Aug 7, 2023

I see, that makes sense. But the readme alone can't crash our coverage from ~80% to ~30%, right?

I have no clue honestly

@samsja samsja marked this pull request as ready for review August 7, 2023 08:57
@samsja samsja merged commit 691d939 into main Aug 7, 2023
@samsja samsja deleted the fix-test branch August 7, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants