feat: add description and example to ID field of BaseDoc #1737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 31, 2023 12:25
Signed-off-by: Joan Fontanals Martinez <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1737 +/- ##
===========================================
+ Coverage 61.53% 84.46% +22.92%
===========================================
Files 134 134
Lines 8840 8838 -2
===========================================
+ Hits 5440 7465 +2025
+ Misses 3400 1373 -2027
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
samsja
approved these changes
Jul 31, 2023
JohannesMessner
approved these changes
Jul 31, 2023
Signed-off-by: Joan Fontanals Martinez <[email protected]>
5b2cb77 to
46bcf5a
Compare
e20feab to
7efbf1e
Compare
Signed-off-by: Joan Fontanals Martinez <[email protected]>
7efbf1e to
c1b4aa5
Compare
|
📝 Docs are deployed on https://ft-feat-add-basedoc-id-example--jina-docs.netlify.app 🎉 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.