Skip to content

fix: add description and title to dynamic class #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jul 29, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (896c20b) 84.46% compared to head (1d342bd) 84.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1734      +/-   ##
==========================================
+ Coverage   84.46%   84.47%   +0.01%     
==========================================
  Files         134      134              
  Lines        8798     8804       +6     
==========================================
+ Hits         7431     7437       +6     
  Misses       1367     1367              
Flag Coverage Δ
docarray 84.47% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
docarray/utils/create_dynamic_doc_class.py 82.97% <100.00%> (+1.16%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Joan Fontanals Martinez <[email protected]>
@JoanFM JoanFM force-pushed the small-fix-dyn-class branch from f9734ce to 1d342bd Compare July 29, 2023 17:34
@github-actions
Copy link

📝 Docs are deployed on https://ft-small-fix-dyn-class--jina-docs.netlify.app 🎉

@JoanFM JoanFM merged commit 87ec19f into main Jul 31, 2023
@JoanFM JoanFM deleted the small-fix-dyn-class branch July 31, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant