Skip to content

fix: create more info from dynamic #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2023
Merged

fix: create more info from dynamic #1733

merged 1 commit into from
Jul 29, 2023

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jul 29, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.01% 🎉

Comparison is base (24c00cc) 84.44% compared to head (942ed17) 84.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1733      +/-   ##
==========================================
+ Coverage   84.44%   84.46%   +0.01%     
==========================================
  Files         134      134              
  Lines        8796     8798       +2     
==========================================
+ Hits         7428     7431       +3     
+ Misses       1368     1367       -1     
Flag Coverage Δ
docarray 84.46% <83.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
docarray/utils/create_dynamic_doc_class.py 81.81% <83.33%> (+0.42%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Joan Fontanals Martinez <[email protected]>
@JoanFM JoanFM force-pushed the fix-keep-extra-info branch from f0c8531 to 942ed17 Compare July 29, 2023 14:26
@github-actions
Copy link

📝 Docs are deployed on https://ft-fix-keep-extra-info--jina-docs.netlify.app 🎉

@JoanFM JoanFM merged commit 896c20b into main Jul 29, 2023
@JoanFM JoanFM deleted the fix-keep-extra-info branch July 29, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant