Skip to content

chore: refactor filter in hnswlib #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2023
Merged

chore: refactor filter in hnswlib #1728

merged 1 commit into from
Jul 26, 2023

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jul 26, 2023

No description provided.

Signed-off-by: Joan Fontanals Martinez <[email protected]>
@github-actions
Copy link

📝 Docs are deployed on https://ft-refactor-filter-hnswlib--jina-docs.netlify.app 🎉

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.86% 🎉

Comparison is base (efeab90) 83.62% compared to head (da749c8) 84.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1728      +/-   ##
==========================================
+ Coverage   83.62%   84.48%   +0.86%     
==========================================
  Files         134      134              
  Lines        8795     8793       -2     
==========================================
+ Hits         7355     7429      +74     
+ Misses       1440     1364      -76     
Flag Coverage Δ
docarray 84.48% <100.00%> (+0.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
docarray/index/backends/hnswlib.py 74.21% <100.00%> (-0.14%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoanFM JoanFM requested a review from jupyterjazz July 26, 2023 11:01
@JoanFM JoanFM merged commit 24143a1 into main Jul 26, 2023
@JoanFM JoanFM deleted the refactor-filter-hnswlib branch July 26, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant