refactor: hnswlib performance #1727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 26, 2023 12:44
Signed-off-by: Joan Fontanals Martinez <[email protected]>
…ctor-hnswlib-performance
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1727 +/- ##
==========================================
- Coverage 84.46% 84.45% -0.01%
==========================================
Files 134 134
Lines 8798 8834 +36
==========================================
+ Hits 7431 7461 +30
- Misses 1367 1373 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Joan Fontanals Martinez <[email protected]>
f7bd4d0 to
3f56d44
Compare
Signed-off-by: Joan Fontanals Martinez <[email protected]>
4f6c270 to
f8bb5f9
Compare
added 3 commits
July 27, 2023 05:56
Signed-off-by: Joan Fontanals Martinez <[email protected]>
…ctor-hnswlib-performance
…ay/docarray into refactor-hnswlib-performance Signed-off-by: Joan Fontanals Martinez <[email protected]>
3b0922a to
79b0fea
Compare
added 5 commits
July 28, 2023 02:02
Signed-off-by: Joan Fontanals Martinez <[email protected]>
…into refactor-hnswlib-performance
…ctor-hnswlib-performance
fdfcb56 to
74a187e
Compare
Signed-off-by: Joan Fontanals Martinez <[email protected]>
74a187e to
8c0bf6c
Compare
|
📝 Docs are deployed on https://ft-refactor-hnswlib-performance--jina-docs.netlify.app 🎉 |
samsja
reviewed
Jul 31, 2023
| @@ -332,7 +340,19 @@ def _filter( | |||
| limit: int, | |||
| ) -> DocList: | |||
| rows = self._execute_filter(filter_query=filter_query, limit=limit) | |||
| return DocList[self.out_schema](self._doc_from_bytes(blob) for _, blob in rows) # type: ignore[name-defined] | |||
| hashed_ids = [doc_id for doc_id, _ in rows] | |||
| embeddings: OrderedDict[str, list] = OrderedDict() | |||
There was a problem hiding this comment.
Why specifically OrderedDict? I think normal dict in python will already be ordered by default
There was a problem hiding this comment.
I would still like to be specific about the requirement for order
jupyterjazz
reviewed
Jul 31, 2023
| @@ -127,7 +132,12 @@ def __init__(self, db_config=None, **kwargs): | |||
| else: | |||
| self._hnsw_indices[col_name] = self._create_index(col_name, col) | |||
| self._logger.info(f'Created a new index for column `{col_name}`') | |||
| if self._hnsw_indices[col_name].space == 'cosine': | |||
| cosine_metric_index_exist = True | |||
There was a problem hiding this comment.
why do we care about this?
There was a problem hiding this comment.
Because for cosine, HNSWLib normalizes the vectors, and then if we retrieve, they have chanded, so no consistent API can be provided
We have observed around 10% improvement |
jupyterjazz
approved these changes
Jul 31, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.