Skip to content

fix: qdrant unable to see index_name #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2023
Merged

fix: qdrant unable to see index_name #1705

merged 2 commits into from
Jul 17, 2023

Conversation

jupyterjazz
Copy link
Contributor

qdrant doc index does not recognize index_name when passed

from docarray import BaseDoc
from docarray.index import QdrantDocumentIndex

class SimpleSchema(BaseDoc):
    title: str

index = QdrantDocumentIndex[SimpleSchema](index_name='index_name')
print(index.index_name)

will print simpleschema

@jupyterjazz jupyterjazz linked an issue Jul 17, 2023 that may be closed by this pull request
bug: qdrant index can not recognize index_name #1704
Closed
6 tasks
@codecov
Copy link

codecov bot commented Jul 17, 2023 •
edited
Loading

Codecov Report

Patch coverage: 89.28% and project coverage change: +0.06 🎉

Comparison is base (a3f6998) 85.88% compared to head (bcc63ec) 85.95%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1705      +/-   ##
==========================================
+ Coverage   85.88%   85.95%   +0.06%     
==========================================
  Files         126      126              
  Lines        7899     7888      -11     
==========================================
- Hits         6784     6780       -4     
+ Misses       1115     1108       -7
Flag Coverage Δ
docarray 85.95% <89.28%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/index/backends/in_memory.py 46.62% <50.00%> (+0.51%) ⬆️
docarray/index/abstract.py 88.64% <71.42%> (-0.10%) ⬇️
docarray/index/backends/elastic.py 90.16% <100.00%> (+0.26%) ⬆️
docarray/index/backends/hnswlib.py 95.27% <100.00%> (+0.35%) ⬆️
docarray/index/backends/qdrant.py 77.53% <100.00%> (+0.04%) ⬆️
docarray/index/backends/redis.py 88.70% <100.00%> (+0.22%) ⬆️
docarray/index/backends/weaviate.py 95.02% <100.00%> (+0.22%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jupyterjazz
test: resolve subindex tests
bcc63ec 
Signed-off-by: jupyterjazz <[email protected]>
@github-actions
Copy link

📝 Docs are deployed on https://ft-fix-qdrant-config--jina-docs.netlify.app 🎉

@jupyterjazz jupyterjazz merged commit d2e1858 into main Jul 17, 2023
@jupyterjazz jupyterjazz deleted the fix-qdrant-config branch July 17, 2023 19:03
@jupyterjazz jupyterjazz mentioned this pull request Jul 18, 2023
Closed
@JoanFM JoanFM mentioned this pull request Jul 24, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM approved these changes

@JohannesMessner JohannesMessner Awaiting requested review from JohannesMessner

@samsja samsja Awaiting requested review from samsja

Assignees
No one assigned
Labels
area/core area/testing size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: qdrant index can not recognize index_name
2 participants
@jupyterjazz @JoanFM