Skip to content

fix: avoid converting doclists in the base index #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

jupyterjazz
Copy link
Contributor

if isinstance(docs, List):
    docs = self._dict_list_to_docarray(docs)

_dict_list_to_docarray expects a list of dictionaries which is then transformed into a DocList. However, since DocList extends List, the condition is true even if docs is already a DocList, which then leads to an error.

We already fixed this in one place but there are other parts too that need an extra check.

Found while working on milvus pr

Signed-off-by: jupyterjazz <[email protected]>
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

📝 Docs are deployed on https://ft-fix-dont-convert-doclist--jina-docs.netlify.app 🎉

@jupyterjazz jupyterjazz marked this pull request as ready for review July 5, 2023 11:27
@jupyterjazz jupyterjazz merged commit f6ce283 into main Jul 5, 2023
@jupyterjazz jupyterjazz deleted the fix-dont-convert-doclist branch July 5, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants