feat: add method to create BaseDoc from schema #1667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joan Fontanals Martinez <[email protected]>
8d3d297 to
4b018d8
Compare
c5580ba to
0ea3a28
Compare
Signed-off-by: Joan Fontanals Martinez <[email protected]>
0ea3a28 to
e5f065f
Compare
JohannesMessner
requested changes
Jun 22, 2023
d4d6b8b to
e2d41f0
Compare
4060c31 to
10204ad
Compare
Co-authored-by: Johannes Messner <[email protected]> Signed-off-by: Joan Fontanals <[email protected]> Signed-off-by: Joan Fontanals Martinez <[email protected]>
10204ad to
be35141
Compare
Signed-off-by: Joan Fontanals Martinez <[email protected]>
4c040a0 to
97c07e5
Compare
samsja
reviewed
Jun 22, 2023
|
📝 Docs are deployed on https://ft-feat-add-create-dynamic-doc--jina-docs.netlify.app 🎉 |
samsja
approved these changes
Jun 22, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is used inside
Jinato dynamically createBaseDocsin services where the actual BaseDoc is not created but still hold the validation capabilities.You can think as being easy to validate the
BaseDocat the driver or client program of a server serving BaseDoc models.