Skip to content

Use one GitHub runner per Python version #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2021
Merged

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Nov 18, 2021

Description of the Change

  • Moving from tox-gh-actions to tox-py (the same as DRF is already using)
  • Move configuration what tests are allowed to fail into tox instead of GitHub settings
  • Simplification of configuration as tox has the lead and no additional configuration is needed for actions.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

* Moving from tox-gh-actions to tox-py (following DRF)
* Move configuration what tests are allowed to failed into
  tox configuration instead of GitHub settings
* Simplification of configuration as tox has the lead and
  no additional configuration is needed.
@sliverc sliverc requested a review from n2ygk November 18, 2021 19:19
@sliverc
Copy link
Member Author

sliverc commented Nov 18, 2021

Support for Django 4.0 (see #1010) would add more complexity in the GitHub action matrix as it does not support all Python versions anymore. With this change supporting new versions of Django or DRF will be easier as only tox needs to be configured and no additional configuration anymore in GitHub project settings.

@n2ygk n2ygk merged commit 83d84d0 into django-json-api:master Nov 18, 2021
@sliverc sliverc deleted the tox-py branch November 19, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants