Skip to content

fix(cubesql): Fix incorrect datetime parsing in filters rewrite rules #9732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 1, 2025
Merged

fix(cubesql): Fix incorrect datetime parsing in filters rewrite rules #9732

merged 5 commits into from
Jul 1, 2025
+87 −54

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Jun 30, 2025 •
edited
Loading

This PR fixes [sometimes] incorrectly parsed date range boudaries literals (not adding/subtracting milisecond).

This fixes #9628

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

@KSDaemon KSDaemon force-pushed the fix/daterange-in-sql-bounds branch from a5a97cf to b75ec12 Compare June 30, 2025 19:31
@codecov Codecov
Copy link

codecov bot commented Jun 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.67123% with 9 lines in your changes missing coverage. Please review.

Project coverage is 84.23%. Comparing base (066045e) to head (f9cf303).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...besql/cubesql/src/compile/rewrite/rules/filters.rs 58.82% 7 Missing ⚠️
rust/cubesql/cubesql/src/compile/date_parser.rs 92.30% 1 Missing ⚠️
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9732      +/-   ##
==========================================
+ Coverage   84.20%   84.23%   +0.02%     
==========================================
  Files         230      231       +1     
  Lines       85321    85341      +20     
==========================================
+ Hits        71847    71886      +39     
+ Misses      13474    13455      -19
Flag Coverage Δ
cubesql 84.23% <87.67%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review June 30, 2025 20:50
@KSDaemon KSDaemon requested a review from a team as a code owner June 30, 2025 20:50
MazterQyou
MazterQyou reviewed Jun 30, 2025
View reviewed changes
@KSDaemon KSDaemon requested a review from MazterQyou June 30, 2025 21:10
MazterQyou
MazterQyou approved these changes Jun 30, 2025
View reviewed changes
@KSDaemon KSDaemon merged commit 6e73860 into master Jul 1, 2025
82 checks passed
@KSDaemon KSDaemon deleted the fix/daterange-in-sql-bounds branch July 1, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MazterQyou MazterQyou MazterQyou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong databricks time range filters.
2 participants
@KSDaemon @MazterQyou