Add JSON Schema validation test; fix typo #2003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds schema payload validation to JSON serialization tests and fixes a typo in the validate flag check within the JSONSerializer initializer.
- Enabled explicit
validate: Truein serializer configs for both sync and async tests - Added
test_json_basic_failing_validationin sync and async to confirm invalid payloads raiseSerializationError - Corrected the boolean check to validate
self._validateinstead ofself._normalize_schemasin both sync and async JSONSerializer implementations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/schema_registry/_sync/test_json_serdes.py | Added validate flag and new failing validation test |
| tests/schema_registry/_async/test_json_serdes.py | Added validate flag, new failing validation test, and minor client instantiation change needed |
| src/confluent_kafka/schema_registry/_sync/json_schema.py | Fixed typo: now checks self._validate is boolean |
| src/confluent_kafka/schema_registry/_async/json_schema.py | Fixed typo: now checks self._validate is boolean |
This comment has been minimized.
This comment has been minimized.
Analysis Details6 Issues
Coverage and Duplications
Project ID: confluent-kafka-python |
kcorman0
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add JSON Schema validation test; fix typo
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups