Fixed non-tool path prefix file names for python conventions #2000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes the EOS transactions example file name to use snake_case and updates all references to match.
- Rename
eos-transactions.pytoeos_transactions.pyin code and docs - Update the producer’s
transactional.idto reflect the new file name - Correct the README example link
Reviewed Changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| examples/eos_transactions.py | Changed transactional.id value from 'eos-transactions.py' to 'eos_transactions.py' |
| examples/README.md | Updated the example link from [eos-transactions.py] to [eos_transactions.py] |
Analysis Details0 Issues
Coverage and Duplications
Project ID: confluent-kafka-python |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor fix to project files to not have multiple conventions.
A few file renames.
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups
I originally changed the files in
tools, but reverted that as they are treated like bash scripts in that folder and all the command line instructions use the same-separators. It felt better to keep it consistent with the.shfiles in that folder.