Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: coder/coder-logstream-kube
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b45e9d5
Choose a base ref
...
head repository: coder/coder-logstream-kube
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9f8558d
Choose a head ref
  • 8 commits
  • 7 files changed
  • 4 contributors

Commits on Jun 3, 2025

  1. Add support for multiple namespaces

    - Allow CODER_NAMESPACE to accept comma-separated list of namespaces
    - Support watching all namespaces when CODER_NAMESPACE is empty
    - Automatically use ClusterRole/ClusterRoleBinding for multi-namespace or all-namespace scenarios
    - Update Helm chart to support both namespace-scoped and cluster-wide RBAC
    - Add comprehensive documentation for multi-namespace usage
    - Maintain backward compatibility with single namespace deployments
    
    Fixes #5
    blink-so[bot] committed Jun 3, 2025
    Configuration menu
    Copy the full SHA
    d2d6be2 View commit details
    Browse the repository at this point in the history
  2. Remove backup files

    blink-so[bot] committed Jun 3, 2025
    Configuration menu
    Copy the full SHA
    efe2bac View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2025

  1. Fix compilation errors and update to current agentsdk API

    - Replace deprecated AgentLogWriter with agentsdk.Client and PatchLogs
    - Fix struct field names in tests (namespace -> namespaces)
    - Add missing isEmpty method to tokenCache
    - Update setPodToken and setReplicaSetToken to return values
    - Fix agentLog struct literals in tests
    - Add PatchLogs endpoint to fake API for tests
    - Update test expectations to match current log message format
    
    Co-authored-by: kylecarbs <[email protected]>
    blink-so[bot] and kylecarbs committed Jun 10, 2025
    Configuration menu
    Copy the full SHA
    ac97429 View commit details
    Browse the repository at this point in the history
  2. Improve async log handling and fix test compatibility

    - Add proper context management to logger goroutines
    - Fix log level conversion in fake API PatchLogs method
    - Improve goroutine lifecycle with cancellation support
    - Use ticker-based approach for more reliable log sending
    - Continue on PatchLogs errors instead of exiting goroutine
    
    Co-authored-by: kylecarbs <[email protected]>
    blink-so[bot] and kylecarbs committed Jun 10, 2025
    Configuration menu
    Copy the full SHA
    f6b43a0 View commit details
    Browse the repository at this point in the history
  3. Improve async log handling and fix test compatibility

    - Fix Test_logQueuer to use real clock and proper timing
    - Add clock advances and sleeps to handle async log processing
    - Improve test reliability for TestPodEvents and TestReplicaSetEvents
    - Use quartz.NewTicker for proper mock clock integration
    - Simplify test expectations for better CI compatibility
    
    Co-authored-by: kylecarbs <[email protected]>
    blink-so[bot] and kylecarbs committed Jun 10, 2025
    Configuration menu
    Copy the full SHA
    8700cc8 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2025

  1. Fix test timeouts by making tick interval configurable

    - Add configurable tickInterval to logQueuer struct
    - Update Test_logQueuer to use real clock with fast tick interval (10ms)
    - Update TestPodEvents and TestReplicaSetEvents to use real clock
    - Replace mock clock advances with real time waits
    - Fix Test_logQueuer test which now passes consistently
    
    The new ticker-based logging implementation requires different timing
    than the original synchronous approach. Tests now use fast tick
    intervals (10ms) with real clocks instead of mock clocks to avoid
    timing conflicts.
    
    Co-authored-by: matifali <[email protected]>
    blink-so[bot] and matifali committed Jun 19, 2025
    Configuration menu
    Copy the full SHA
    68df1af View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e95d523 View commit details
    Browse the repository at this point in the history
  3. Address review comments

    - Restore discord and godoc badges in README.md
    - Fix release link to point to correct repository releases page
    - Use consistent naming for namespace-scoped Role with release prefix
    - Clean up commented-out legacy securityContext lines in values.yaml
    
    The sourceUUID variable is actually used in tests so no changes needed there.
    YAML formatting in service.yaml is already correct.
    
    Co-authored-by: matifali <[email protected]>
    blink-so[bot] and matifali committed Jun 19, 2025
    Configuration menu
    Copy the full SHA
    9f8558d View commit details
    Browse the repository at this point in the history
Loading