Skip to content

feat: Show custom resource icons #4020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 13, 2022
Merged

feat: Show custom resource icons #4020

merged 14 commits into from
Sep 13, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Closes #3487

Sending it as a draft first to check if I'm missing something in the BE.

@BrunoQuaresma BrunoQuaresma requested a review from a team September 12, 2022 17:03
@BrunoQuaresma BrunoQuaresma self-assigned this Sep 12, 2022
@BrunoQuaresma
Copy link
Collaborator Author

I also would appreciate a guidance on how to test this change.

Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! I see the frontend still has to be done, but all the backend code looks great.

@BrunoQuaresma BrunoQuaresma marked this pull request as ready for review September 13, 2022 14:02
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner September 13, 2022 14:02
@BrunoQuaresma BrunoQuaresma requested review from code-asher and removed request for a team September 13, 2022 14:02
@BrunoQuaresma BrunoQuaresma merged commit 214e594 into main Sep 13, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/3487 branch September 13, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow coder_metadata to set the icon for a resource
2 participants