feat(cli): improve devcontainer support for coder show
#18793
Conversation
| { | ||
| Flag: "details", | ||
| Description: "Show full error messages and additional details.", | ||
| Value: serpent.BoolOf(&details), |
There was a problem hiding this comment.
Suggestion: explicit default value
There was a problem hiding this comment.
I added it but it changes the CLI output to show default false. Not sure I like that to be honest since it's kinda clear that that's already the case. But either way works for me.
There was a problem hiding this comment.
I'm easy either way, having an explicit default is easier to read but if it negatively impacts the help output we can skip it.
There was a problem hiding this comment.
but if it negatively impacts the help output we can skip it.
wdyt? 2eab390 (#18793)
There was a problem hiding this comment.
Alright. IMO it's somewhat of a bug in serpent, doesn't really make sense to render the two cases differently and it could already inherit the default value from the current value of the variable given as pointer ¯\_(ツ)_/¯.
Fixes coder/internal#747