Skip to content

chore: implement tests for dynamic parameter component #18745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 3, 2025

Conversation

jaaydenh
Copy link
Contributor

@jaaydenh jaaydenh commented Jul 3, 2025

No description provided.

@jaaydenh jaaydenh self-assigned this Jul 3, 2025
@jaaydenh jaaydenh changed the title chore: Dynamic Paramater component tests chore: dynamic Parameter component tests Jul 3, 2025
@jaaydenh jaaydenh changed the title chore: dynamic Parameter component tests chore: implement tests for dynamic parameter component Jul 3, 2025
@jaaydenh jaaydenh requested a review from aslilac July 3, 2025 15:46
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer that rather than one big long set of constants at the top, they be defined inside the describe the parameter is used in. feels a little weird to have to scroll so far to get to the first actual test. but overall looks good.

@jaaydenh
Copy link
Contributor Author

jaaydenh commented Jul 3, 2025

@aslilac some of the parameter constants are shared but I can move the ones that are not shared closer to the actual test.

@jaaydenh jaaydenh merged commit 90a875d into main Jul 3, 2025
33 checks passed
@jaaydenh jaaydenh deleted the jaaydenh/Dynamic-parameter-component-tests branch July 3, 2025 17:10
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants