feat: use preview to compute workspace tags from terraform #18720
+1,183
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6c1fdf5 to
20d0254
Compare
15a6ca1 to
f0dd768
Compare
6f3d388 to
f4cd152
Compare
f0dd768 to
a87678d
Compare
29a7cf6 to
4d06a6c
Compare
Emyrk
commented
Jul 2, 2025
| "github.com/coder/coder/v2/testutil" | ||
| ) | ||
|
|
||
| func Test_DynamicWorkspaceTagDefaultsFromFile(t *testing.T) { |
There was a problem hiding this comment.
This test is copied from tfparse_test.go.
The tfparse test can be removed when this becomes the new standard.
96c83c7 to
8d594a7
Compare
fc1ad45 to
11e0407
Compare
3cc9349 to
699dd8e
Compare
11e0407 to
d1ed169
Compare
6460c4c to
35d29b9
Compare
35d29b9 to
ea564d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
If using dynamic parameters, workspace tags are extracted using
coder/preview. This occurs at template version import and workspace create.Templates that are not opted into dynamic parameters will use
tfparse.Future Work
When
previewis used as the source of truth for tags, we can removetfparse.Closes coder/internal#698