feat: implement terminal reconnection UI components (Phase 2) #18695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create TerminalRetryConnection component with countdown display and retry button - Add comprehensive Storybook stories covering all retry states - Integrate component with TerminalAlerts for proper positioning - Use consistent TerminalAlert styling for seamless integration - Ensure proper resize handling through existing MutationObserver Implements Phase 2 of terminal reconnection feature as outlined in: coder/internal#659 Co-authored-by: BrunoQuaresma <[email protected]>
- Change 'import type { FC }' to 'import { type FC }' to match existing patterns
- Verified with prettier that formatting is correct
Co-authored-by: BrunoQuaresma <[email protected]>
…ectedAlert - Simplify TerminalRetryConnection to show only retry status and button - Keep existing DisconnectedAlert but add TerminalRetryConnection in actions - Use TailwindCSS classes instead of CSS-in-JS - Place retry component on the right side of the alert - Make retry messages smaller and more concise - Fix console.log usage in Storybook stories Co-authored-by: BrunoQuaresma <[email protected]>
- Remove RefreshSessionButton from DisconnectedAlert actions - Keep only TerminalRetryConnection component in the actions area - Simplify the actions layout by removing the wrapper div Co-authored-by: BrunoQuaresma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Phase 2 of terminal reconnection feature as outlined in: coder/internal#659