Skip to content

fix: handle task sidebar app health check disabled correctly #18687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
Merged

fix: handle task sidebar app health check disabled correctly #18687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion site/src/pages/TaskPage/TaskPage.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ export const TerminatedBuildWithStatus: Story = {
},
};

export const SidebarAppDisabled: Story = {
export const SidebarAppHealthDisabled: Story = {
beforeEach: () => {
spyOn(data, "fetchTask").mockResolvedValue({
prompt: "Create competitors page",
Expand Down
4 changes: 3 additions & 1 deletion site/src/pages/TaskPage/TaskSidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,10 @@ const getSidebarApp = (task: Task): [WorkspaceApp | null, SidebarAppStatus] => {
// indefinitely if there's a genuine issue, but this is preferable to false error alerts.
return [null, "loading"];
}
// "disabled" means that the health check is disabled, so we assume
// that the app is healthy
if (sidebarApp.health === "disabled") {
return [sidebarApp, "error"];
return [sidebarApp, "healthy"];
}
if (sidebarApp.health === "healthy") {
return [sidebarApp, "healthy"];
Expand Down
Loading