fix(agent/agentcontainers): reset error at start of rebuild #18686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that any previous error on a devcontainer is cleared when a rebuild is started and updates test fakes to support deferred error injection via functions.
- Clear the
Errorfield at the start ofhandleDevcontainerRecreate - Change
fakeDevcontainerCLI.upErrCto carryfunc() errorinstead of rawerror - Update tests to send error-producing functions and verify the cleared error
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| agent/agentcontainers/api.go | Reset dc.Error to an empty string before recreate |
| agent/agentcontainers/api_test.go | Switch upErrC channel to func() error and adjust tests |
Comments suppressed due to low confidence (2)
agent/agentcontainers/api_test.go:72
- Update the comment to reflect that
upErrCreceivesfunc() errorvalues, e.g. "If set, send a function that returns the desired error".
upErrC chan func() error // If set, send to return err, close to return upErr.
agent/agentcontainers/api_test.go:72
- [nitpick] Consider renaming
upErrCtoupErrFnC(and similarlyexecErrCtoexecErrFnC) to clearly indicate that the channel carries functions rather than raw errors.
upErrC chan func() error // If set, send to return err, close to return upErr.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resets the error when a rebuild is initiated.