-
Notifications
You must be signed in to change notification settings - Fork 928
feat: add MCP HTTP server endpoint with authentication #18670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,137 @@ | ||
package mcp | ||
|
||
import ( | ||
"bytes" | ||
"context" | ||
"encoding/json" | ||
"fmt" | ||
"net/http" | ||
"time" | ||
|
||
"github.com/mark3labs/mcp-go/mcp" | ||
"github.com/mark3labs/mcp-go/server" | ||
"golang.org/x/xerrors" | ||
|
||
"cdr.dev/slog" | ||
|
||
"github.com/coder/coder/v2/buildinfo" | ||
"github.com/coder/coder/v2/codersdk" | ||
"github.com/coder/coder/v2/codersdk/toolsdk" | ||
) | ||
|
||
const ( | ||
// MCPServerName is the name used for the MCP server. | ||
MCPServerName = "Coder" | ||
// MCPServerInstructions is the instructions text for the MCP server. | ||
MCPServerInstructions = "Coder MCP Server providing workspace and template management tools" | ||
) | ||
|
||
// Server represents an MCP HTTP server instance | ||
type Server struct { | ||
Logger slog.Logger | ||
|
||
// mcpServer is the underlying MCP server | ||
mcpServer *server.MCPServer | ||
|
||
// streamableServer handles HTTP transport | ||
streamableServer *server.StreamableHTTPServer | ||
} | ||
|
||
// NewServer creates a new MCP HTTP server | ||
func NewServer(logger slog.Logger) (*Server, error) { | ||
// Create the core MCP server | ||
mcpSrv := server.NewMCPServer( | ||
MCPServerName, | ||
buildinfo.Version(), | ||
server.WithInstructions(MCPServerInstructions), | ||
) | ||
|
||
// Create logger adapter for mcp-go | ||
mcpLogger := &mcpLoggerAdapter{logger: logger} | ||
|
||
// Create streamable HTTP server with configuration | ||
streamableServer := server.NewStreamableHTTPServer(mcpSrv, | ||
server.WithHeartbeatInterval(30*time.Second), | ||
server.WithLogger(mcpLogger), | ||
) | ||
|
||
return &Server{ | ||
Logger: logger, | ||
mcpServer: mcpSrv, | ||
streamableServer: streamableServer, | ||
}, nil | ||
} | ||
|
||
// ServeHTTP implements http.Handler interface | ||
func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) { | ||
s.streamableServer.ServeHTTP(w, r) | ||
} | ||
|
||
// RegisterTools registers all available MCP tools with the server | ||
func (s *Server) RegisterTools(client *codersdk.Client) error { | ||
// Create tool dependencies | ||
toolDeps, err := toolsdk.NewDeps(client) | ||
if err != nil { | ||
return xerrors.Errorf("failed to initialize tool dependencies: %w", err) | ||
} | ||
|
||
// Register all available tools | ||
for _, tool := range toolsdk.All { | ||
// Skip user-dependent tools if no authenticated client | ||
if !tool.UserClientOptional && client == nil { | ||
s.Logger.Warn(context.Background(), "tool requires authentication and will not be available", slog.F("tool", tool.Name)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion: just warn once with missing tools, otherwise this will spam There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I copy & pasted this from the CLI implementation, but in the HTTP server's case, there will never be a situation where no token/client is present and this should never be logged. I'll remove this log and checks. |
||
continue | ||
} | ||
|
||
s.mcpServer.AddTools(mcpFromSDK(tool, toolDeps)) | ||
} | ||
|
||
return nil | ||
} | ||
|
||
// mcpFromSDK adapts a toolsdk.Tool to go-mcp's server.ServerTool | ||
func mcpFromSDK(sdkTool toolsdk.GenericTool, tb toolsdk.Deps) server.ServerTool { | ||
if sdkTool.Schema.Properties == nil { | ||
panic("developer error: schema properties cannot be nil") | ||
} | ||
|
||
return server.ServerTool{ | ||
Tool: mcp.Tool{ | ||
Name: sdkTool.Name, | ||
Description: sdkTool.Description, | ||
InputSchema: mcp.ToolInputSchema{ | ||
Type: "object", | ||
Properties: sdkTool.Schema.Properties, | ||
Required: sdkTool.Schema.Required, | ||
}, | ||
}, | ||
Handler: func(ctx context.Context, request mcp.CallToolRequest) (*mcp.CallToolResult, error) { | ||
var buf bytes.Buffer | ||
if err := json.NewEncoder(&buf).Encode(request.Params.Arguments); err != nil { | ||
return nil, xerrors.Errorf("failed to encode request arguments: %w", err) | ||
} | ||
result, err := sdkTool.Handler(ctx, tb, buf.Bytes()) | ||
if err != nil { | ||
return nil, err | ||
} | ||
return &mcp.CallToolResult{ | ||
Content: []mcp.Content{ | ||
mcp.NewTextContent(string(result)), | ||
}, | ||
}, nil | ||
}, | ||
} | ||
} | ||
|
||
// mcpLoggerAdapter adapts slog.Logger to the mcp-go util.Logger interface | ||
type mcpLoggerAdapter struct { | ||
logger slog.Logger | ||
} | ||
|
||
func (l *mcpLoggerAdapter) Infof(format string, v ...any) { | ||
l.logger.Info(context.Background(), fmt.Sprintf(format, v...)) | ||
} | ||
|
||
func (l *mcpLoggerAdapter) Errorf(format string, v ...any) { | ||
l.logger.Error(context.Background(), fmt.Sprintf(format, v...)) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to hide this behind a flag or experiment perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I added an experiment up the stack in: #18712